Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value for nthreads in montecarlo schema to 0 #705

Closed
wants to merge 2 commits into from
Closed

Set default value for nthreads in montecarlo schema to 0 #705

wants to merge 2 commits into from

Conversation

saurvs
Copy link

@saurvs saurvs commented Feb 3, 2017

Addresses #699.

This ensures to that, if nthreads isn't specified, the value of the OMP_NUM_THREADS environment variable is used by OpenMP instead of 1.

This ensures to that, if nthreads isn't specified,
the value of the OMP_NUM_THREADS environment variable
is used by OpenMP instead of 1.
@wkerzendorf
Copy link
Member

@saurvs okay - now go and find something more difficult ;-)

@saurvs
Copy link
Author

saurvs commented Feb 3, 2017

@wkerzendorf Sure :). I also found some typo's in setup.py and put it in this PR. Is that okay or should I make a separate PR?

@yeganer
Copy link
Contributor

yeganer commented Feb 3, 2017

I think changing the typos in setup.py doesn't need a separate PR as they are thematically linked

@wkerzendorf
Copy link
Member

@tardis-sn/tardis-core we'll merge this later

@wkerzendorf wkerzendorf closed this Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants