-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenMP] Use OMP_NUM_THREADS by default #699
Comments
Hello I'm a new contributor here and I'd like to take a stab at this. |
@yeganer -- is this still relevant? |
@yeganer, @wkerzendorf - I just had a look at this issue and came to the following conclusions:
Based on these findings, I'd advocate not to change the default value, since it would most likely lead to the undesired outcomes for inexperienced users who have not set |
From my perspective - by default - TARDIS should use the maximum number of threads available. That means the default value should be 0 (not visible in the configuration file), but we should have in our examples nthreads=1 commented out so people see how they can change the number of threads. |
Ok, I think I can live with that. I'll include it in my PR. |
Resolved by #797. |
If the configuration is missing
montecarlo.nthreads
use the OpenMP default value for parallelization.On the C level this is already possible by calling
montecarlo_main_loop
withnthreads=0
.All that is left to do is change the default value in the yaml schema and verify this is working as expected.
The text was updated successfully, but these errors were encountered: