Fixed the Failing Documentation for Tracking RPacket Feature
#1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umber of interactions
DhruvSondhi
requested review from
wkerzendorf,
Rodot-,
andrewfullard and
isaacgsmith
|
Before a pull request is accepted, it must meet the following criteria:
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #1841 +/- ##
==========================================
- Coverage 57.66% 57.65% -0.01%
==========================================
Files 66 66
Lines 6808 6809 +1
==========================================
Hits 3926 3926
- Misses 2882 2883 +1
Continue to review full report at Codecov.
|
isaacgsmith
previously requested changes
Dec 13, 2021
DhruvSondhi
force-pushed
the
rpacket_docs_fix
branch
from
40618bd to
d1729db
Compare
DhruvSondhi
force-pushed
the
rpacket_docs_fix
branch
8 times, most recently
from
31524b8 to
ae05cc2
Compare
DhruvSondhi
force-pushed
the
rpacket_docs_fix
branch
from
ae05cc2 to
9447589
Compare
andrewfullard
approved these changes
Dec 13, 2021
Rodot-
approved these changes
Dec 13, 2021
andrewfullard
dismissed
isaacgsmith’s stale review
Changes addressed, merge is urgent
DhruvSondhi
added a commit
to DhruvSondhi/tardis
that referenced
this pull request
Dec 14, 2021
…s-sn#1841) * Fixed shell_id array not being re-adjusted to finalize the size for number of interactions * Changed the documentation for RPacket Tracking to accomodate the recent changes * Removed output from documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the merging of #1748, the documentation pipeline on master is failing as the documentation for the same was not updated to take into consideration the new changes done to the tracking functionality. This PR aims to fix this issue with the addition of a missing functionality. It adds the finalization of the
shell_idarray in theRPacketCollectionClass.Description
Same as above.
Motivation and context
Fixes the failing documentation pipeline after the recent merger.
How has this been tested?
Type of change
Checklist
Check for the preview of the Documentation here : https://dhruvsondhi.github.io/tardis/branch/rpacket_docs_fix/io/output/rpacket_tracking.html