-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking RPacket Properties in Montecarlo Single Packet Loop Function #1748
Conversation
Before a pull request is accepted, it must meet the following criteria:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial Draft that allows logging Packet Properties to a File.
Codecov Report
@@ Coverage Diff @@
## master #1748 +/- ##
==========================================
- Coverage 58.04% 57.66% -0.38%
==========================================
Files 66 66
Lines 6747 6808 +61
==========================================
+ Hits 3916 3926 +10
- Misses 2831 2882 +51
Continue to review full report at Codecov.
|
Apologies, I didn't realise this was marked draft! |
1be5704
to
2fd2368
Compare
3743682
to
35e51aa
Compare
bd331ad
to
b6c989d
Compare
981490b
to
4df3b70
Compare
9e7512c
to
0b04d28
Compare
…e resultant arrays in RPacketCollection
…rable via the YAML Config
Changed the implementation of the finalize_array function to reduce the array size Implemented tests with Setup & Teardown mechanics for INITIAL_TRACKING_ARRAY_LENGTH
Removed track_r_packet func from r_packet.py
Renamed tracked_rpacket to rpacket_tracker
a0ff34a
to
6a804fc
Compare
Need to change a test. please don't merge until I push the changes to the test :) |
There is an issue with the documentation here. It needs to be fixed. I am working on it. |
This PR aims to add tracking functionality to Single Packet Loop via a new
RPacketCollection
Jitclass. It tracks all the properties to a single instance of theRPacketCollection
class. The class object has the following properties available to access for the tracked packets:index
of the packetsseed
of the packetsstatus
of the packetsr
(radius) of the packetsnu
of the packetsmu
of the packetsenergy
of the packetsDescription
Functionality to Track R_Packet interactions with the respective properties. It tracks every interaction for each packet.
Stored in a
RPacketCollection
Class object namelyr_packet_track
Motivation and context
Important for visualising the montecarlo packets. Allows to debug the interactions a packet may undergo.
Documentation Preview
https://dhruvsondhi.github.io/tardis/branch/packet_tracking/io/output/rpacket_tracking.html
How has this been tested?
Type of change
Checklist