Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to enable virtual packet logging #1508

Closed
wants to merge 1 commit into from

Conversation

karban8
Copy link

@karban8 karban8 commented Mar 23, 2021

Description

This PR is an attempt to fix issue #1374
The configuration file has been updated and suitable instructions have been added in the jupyter notebook (enable_virtual_generating_widgets.ipynb)

Motivation and Context

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Other (please describe)

Screenshots (if appropriate):

Screenshot from 2021-03-24 00-44-55
Screenshot from 2021-03-24 00-45-49
Screenshot from 2021-03-24 00-44-31

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #1508 (8a3c975) into master (47010f8) will not change coverage.
The diff coverage is n/a.

❗ Current head 8a3c975 differs from pull request most recent head 7c207c7. Consider uploading reports for the commit 7c207c7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1508   +/-   ##
=======================================
  Coverage   68.12%   68.12%           
=======================================
  Files          68       68           
  Lines        6040     6040           
=======================================
  Hits         4115     4115           
  Misses       1925     1925           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47010f8...7c207c7. Read the comment docs.

@karban8 karban8 marked this pull request as ready for review March 23, 2021 19:43
@karban8
Copy link
Author

karban8 commented Mar 24, 2021

@jaladh-singhal Please review my PR. Thanks

@andrewfullard
Copy link
Contributor

Note that with the merge of #1498 this documentation needs to be updated to include the second way of enabling virtual packet logging. Furthermore, I am not sure that an explicit new notebook is needed to show how this works. Rather, a new section of text in the visualization notebook that this is based on should be enough.

@karban8
Copy link
Author

karban8 commented Mar 25, 2021

Note that with the merge of #1498 this documentation needs to be updated to include the second way of enabling virtual packet logging. Furthermore, I am not sure that an explicit new notebook is needed to show how this works. Rather, a new section of text in the visualization notebook that this is based on should be enough.

Alright I will incorporate the new changes. Also at first at I did try in the generating_widgets notebook (present in docs/using/visualization) but run_tardis(tardis_example.yml) gives a 'file not found' error though it is present in /docs/using

@andrewfullard andrewfullard marked this pull request as draft March 26, 2021 19:01
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to continue with this?

@jaladh-singhal
Copy link
Member

run_tardis(tardis_example.yml) gives a 'file not found' error though it is present in /docs/using
Because it needs to be present in docs/using/visualization - same directory where notebook lives.

Copy link
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like @andrewfullard pointed out, there's no need of separate notebook. This should instead be a warning box in "Line Info Widget" section's starting - exact same as in existing sdec_plot notebook.

@marxwillia
Copy link
Contributor

Closing due to inactivity. Happy to reopen if work resumes.

@marxwillia marxwillia closed this May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants