-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions to enable virtual packet logging #1508
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #1508 +/- ##
=======================================
Coverage 68.12% 68.12%
=======================================
Files 68 68
Lines 6040 6040
=======================================
Hits 4115 4115
Misses 1925 1925 Continue to review full report at Codecov.
|
@jaladh-singhal Please review my PR. Thanks |
Note that with the merge of #1498 this documentation needs to be updated to include the second way of enabling virtual packet logging. Furthermore, I am not sure that an explicit new notebook is needed to show how this works. Rather, a new section of text in the visualization notebook that this is based on should be enough. |
Alright I will incorporate the new changes. Also at first at I did try in the generating_widgets notebook (present in docs/using/visualization) but run_tardis(tardis_example.yml) gives a 'file not found' error though it is present in /docs/using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan to continue with this?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like @andrewfullard pointed out, there's no need of separate notebook. This should instead be a warning box in "Line Info Widget" section's starting - exact same as in existing sdec_plot notebook.
Closing due to inactivity. Happy to reopen if work resumes. |
Description
This PR is an attempt to fix issue #1374
The configuration file has been updated and suitable instructions have been added in the jupyter notebook (enable_virtual_generating_widgets.ipynb)
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: