-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: add virtual-packet-logging option to run_tardis() #1498
Feature request: add virtual-packet-logging option to run_tardis() #1498
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1498 +/- ##
=======================================
Coverage 68.12% 68.12%
=======================================
Files 68 68
Lines 6040 6040
=======================================
Hits 4115 4115
Misses 1925 1925
Continue to review full report at Codecov.
|
Thank you for this contribution! Please look at the results of failing checks and adjust appropriately. In particular, apply |
Thanks for your kind reminder. I made some additions to the docstring and reformatted the files. Please review my work. |
290af0a
to
219c639
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuyizheng1112 this looks good. Just to make sure everything is alright, can you post output of sim.runner.virt_logging
for both cases?
I've post the screenshot of new output. Please review it :) |
…ardis-sn#1498) * add new parameter to initialize virtual-packet-logging * add docstring * reformat files with black
Description
This PR is to resolve #1356.
Motivation and Context
The virtual packet data is not enabled by default. Currently, we have to enable
virtual_packet_logging
by editing the configuration file to use visualization tools that require virtual packet data. Although offering instruction in the documentation can partly solve the problem, it is still inconvenient to edit configuration file every time.The new feature allows us to enable
virtual_packet_logging
option while running TARDIS simulation by setting the parametervirtual_packet_logging=True
. The default value of the parameter isFalse
. Meanwhile, it still supports specifying the option in configuration files.How Has This Been Tested?
Screenshots (if appropriate):
The output of
virt_packet_last_interaction_type
indicates whether the packet has been enabled.Types of changes
Checklist: