Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved staticmethods of line_info module to a dedicated plot_util module #1340

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

jaladh-singhal
Copy link
Member

  • It moves two static methods in line_info module to plot_util module so that they can be reused by plotly plotting methods in kromer_plot module I'm developing at Add modified Kromer plot to work with widgets #1241
  • Adds option to specify label_text in axis_label_in_latex() as latex string (very minor change)

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #1340 (caa3daf) into master (d4909f1) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   81.57%   81.57%   -0.01%     
==========================================
  Files          46       47       +1     
  Lines        3799     3804       +5     
==========================================
+ Hits         3099     3103       +4     
- Misses        700      701       +1     
Impacted Files Coverage Δ
tardis/tardis/widgets/line_info.py 95.86% <0.00%> (-0.30%) ⬇️
tardis/tardis/widgets/plot_util.py 93.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4909f1...caa3daf. Read the comment docs.

@marxwillia marxwillia merged commit 071a48e into tardis-sn:master Nov 10, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Moved staticmethods of line_info module to a dedicated plot_util module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants