Add modified Kromer plot to work with widgets #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1241 +/- ##
==========================================
- Coverage 72.38% 70.04% -2.34%
==========================================
Files 66 67 +1
Lines 5098 5312 +214
==========================================
+ Hits 3690 3721 +31
- Misses 1408 1591 +183
Continue to review full report at Codecov.
|
jaladh-singhal
force-pushed
the
widgets/kromer_plot
branch
from
4355fa1 to
c9ead8e
Compare
jaladh-singhal
force-pushed
the
widgets/kromer_plot
branch
from
e412547 to
27f98ea
Compare
jaladh-singhal
force-pushed
the
widgets/kromer_plot
branch
2 times, most recently
from
238bca6 to
f1d18c6
Compare
jaladh-singhal
force-pushed
the
widgets/kromer_plot
branch
from
37059ba to
25089cf
Compare
jaladh-singhal
force-pushed
the
widgets/kromer_plot
branch
from
25089cf to
aac6314
Compare
jaladh-singhal
force-pushed
the
widgets/kromer_plot
branch
from
aac6314 to
cc0303e
Compare
jaladh-singhal
force-pushed
the
widgets/kromer_plot
branch
from
cc0303e to
bcce86a
Compare
Does not depend on minimal_model and contains data of both real & virtual mode
This uses tardis-sn/tardisanalysis#35 Co-authored-by: Marc Williamson <[email protected]>
And created a spectrum_frequency as a separate property for storing bins[:-1]
And for finding mid point to plot hidden scatter trace in center
jaladh-singhal
force-pushed
the
widgets/kromer_plot
branch
from
bcce86a to
af4380a
Compare
jaladh-singhal
commented
Dec 15, 2020
marxwillia
reviewed
Dec 18, 2020
marxwillia
reviewed
Dec 18, 2020
marxwillia
reviewed
Dec 18, 2020
marxwillia
reviewed
Dec 18, 2020
marxwillia
reviewed
Dec 18, 2020
| should be a quantity having units of Angstrom, containing two | ||
| values - lower lambda and upper lambda i.e. | ||
| [lower_lambda, upper_lambda] * u.AA | ||
| distance : astropy.Quantity |
There was a problem hiding this comment.
@marxwillia test that the distance actually works.
marxwillia
reviewed
Dec 18, 2020
| self.plot_frequency = self.data[packets_mode].spectrum_frequency | ||
|
|
||
| # Filter their plottable range based on packet_wvl_range specified | ||
| if packet_wvl_range: |
There was a problem hiding this comment.
Plan is to merge, make a separate issue, fix any colormap bugs in separate PR.
marxwillia
reviewed
Dec 18, 2020
marxwillia
reviewed
Dec 18, 2020
marxwillia
reviewed
Dec 18, 2020
marxwillia
reviewed
Dec 18, 2020
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
…plot Add modified Kromer plot to work with widgets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Kromer plot from tardisanalysis in simplified structure so that it can work with widgets being developed. The main changes made are:
To-dos
Note
Since this PR is already pretty bulky, documentation notebook and unit tests will be added in separate PR