Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used format strings throughout TARDIS #1315

Closed
wants to merge 13 commits into from

Conversation

WinstonPais
Copy link

Description

Motivation and Context

#1205

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #1315 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
- Coverage   81.57%   81.53%   -0.05%     
==========================================
  Files          46       46              
  Lines        3799     3801       +2     
==========================================
  Hits         3099     3099              
- Misses        700      702       +2     
Impacted Files Coverage Δ
tardis/tardis/io/atom_data/base.py 90.11% <0.00%> (-1.07%) ⬇️
tardis/tardis/io/decay.py 89.65% <0.00%> (ø)
tardis/tardis/util/base.py 77.77% <0.00%> (ø)
tardis/tardis/plasma/base.py 58.27% <0.00%> (ø)
tardis/tardis/io/model_reader.py 97.70% <0.00%> (ø)
tardis/tardis/simulation/base.py 85.54% <0.00%> (ø)
tardis/tardis/io/atom_data/util.py 47.05% <0.00%> (ø)
tardis/tardis/plasma/exceptions.py 87.50% <0.00%> (ø)
tardis/tardis/io/config_internal.py 34.48% <0.00%> (ø)
tardis/tardis/widgets/shell_info.py 96.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0fce2e...c73e991. Read the comment docs.

@wkerzendorf
Copy link
Member

looks - good at christian + Andreas into Co-authored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants