Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use format strings throughout TARDIS #1205

Closed
wkerzendorf opened this issue Jun 26, 2020 · 3 comments
Closed

Use format strings throughout TARDIS #1205

wkerzendorf opened this issue Jun 26, 2020 · 3 comments

Comments

@wkerzendorf
Copy link
Member

We mostly use the old-style version of string formatting "hello {0}".format(world_str) in py36 we can now switch to f"hello {world_str}" - we should use this throughout TARDIS

@abhaydhiman
Copy link

abhaydhiman commented Aug 13, 2020

@wkerzendorf Can I work on this?

@shrey27tri01
Copy link

@wkerzendorf Can I take up this task?

@yashagg2001
Copy link
Contributor

I changed string formatting from .format() to f-string formatting in all the files. Please check it. #1386

@andrewfullard andrewfullard linked a pull request Dec 15, 2020 that will close this issue
andrewfullard added a commit that referenced this issue Apr 21, 2021
* string formatting done

* Update conf.py

* Update widgets.py

* Update atom_web_download.py

* Update base.py

* Update base.py

* Update util.py

* Update blondin_toymodel.py

* Update config_internal.py

* Update config_validator.py

* Update decay.py

* Update model_reader.py

* Update density.py

* Update spectrum.py

* Update atomic.py

* Update base.py

* Update ion_population.py

* Update nlte.py

* Update test_complete_plasmas.py

* Update base.py

* Update exceptions.py

* Update base.py

* Update atom_data.py

* Update conftest.py

* Update plot_helpers.py

* Update report.py

* Update runner.py

* Update test_integration.py

* Update test_tardis_full.py

* Update test_tardis_full_formal_integral.py

* Update base.py

* Update shell_info.py

* Update analysis.py

* Delete tempCodeRunnerFile.py

* Delete tempCodeRunnerFile.py

* Delete tempCodeRunnerFile.py

* Delete tempCodeRunnerFile.py

* Delete tempCodeRunnerFile.py

* Delete tempCodeRunnerFile.py

* Update config_internal.py

* Applied black formatting

Co-authored-by: Himanshu <[email protected]>
Co-authored-by: Andrew Fullard <[email protected]>
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this issue Oct 1, 2021
* string formatting done

* Update conf.py

* Update widgets.py

* Update atom_web_download.py

* Update base.py

* Update base.py

* Update util.py

* Update blondin_toymodel.py

* Update config_internal.py

* Update config_validator.py

* Update decay.py

* Update model_reader.py

* Update density.py

* Update spectrum.py

* Update atomic.py

* Update base.py

* Update ion_population.py

* Update nlte.py

* Update test_complete_plasmas.py

* Update base.py

* Update exceptions.py

* Update base.py

* Update atom_data.py

* Update conftest.py

* Update plot_helpers.py

* Update report.py

* Update runner.py

* Update test_integration.py

* Update test_tardis_full.py

* Update test_tardis_full_formal_integral.py

* Update base.py

* Update shell_info.py

* Update analysis.py

* Delete tempCodeRunnerFile.py

* Delete tempCodeRunnerFile.py

* Delete tempCodeRunnerFile.py

* Delete tempCodeRunnerFile.py

* Delete tempCodeRunnerFile.py

* Delete tempCodeRunnerFile.py

* Update config_internal.py

* Applied black formatting

Co-authored-by: Himanshu <[email protected]>
Co-authored-by: Andrew Fullard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants