Tani multi library v01 #20
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathjax-config.js so that plainText mode works again.
Wrap answer previews in `<script type="math/tex"></script>` tags in the attempts table
then the problem seed passed in the inputs_ref to renderProblem is not used. The one stored in the database is used instead. So pass that on to formatRenderProblem to store in the hidden input.
for the docker build.
docker build so that svg images work there.
somethine that appears to be an array or hash reference actually works as such before attempting to use it as such.
Increment number of items in achievements rather than setting to 1.
use of uninitialized values in strings that would show up if `use warnings` were enabled.
Fix POD generation errors.
was done for the problem seed for an actual problem from the database.
passed on to the format. This is only implemented in the simple format.
…xmlrpc Improve renderViaXMLRPC (webwork2/html2xml) and use it in ProblemSetDetail2.pm and SetMaker.pm
pull request openwebwork#1301. There are also a few tweaks to the simple format as well. Mainly just adding the answer blank coloration (but only if it is not an answer preview and is a submit or check answers).
fix! This fixes issue openwebwork#1323.
Consider individual deadlines when evaluating achievements.
Fixing some achievements (third_time, persistence, super_persistence)
Use current submission result in achievement calculations
reverse negated condition syntax
…urls-for-set-0 Fix the feedback urls for set0. This only affects set0.
Fixing Night Owl, Last Minute and Crack o dawn achievements
Bugfix: JITAR problem sets 'save' not respecting nested problems
when $lti_check_prior is enabled. This bug was causing grade passback to fail when $lti_check_prior was not enabled after the first call until the LMS expired the nonce which was being reused.
…he LMS from 5 seconds to 15 seconds
Hotfix: LTI grade passback
… to openwebwork.org and to installation manuals. Some other small changes.
Fix readme 2.16
Error with utf8 characters when exporting classlist.
…te-mathquill-url update location of mathquill files
appropriate strings get into the translation files properly. In the initial release of WW 2.16 the title of the "Import" tab disappeared from the translation files, and it was later noticed that the titles of the second stage tabs were also not available for translation in either WW 2.15 or WW 2.16. See discussion at openwebwork#1477
strings get added. Due to other recent minor changes, the line numbers on a very large number of strings are also being updated.
…anslation Fix for issue 1477 - uses a revised method of getting "tab titles" in Classlist editor / Homework set editor /Achiev ement editor into the translation files
This fixes issue openwebwork#1488. Thanks for pointing this out @jutrembBDEB.
(Same as a090895, but on the develop branch.)
Fix minor perl mistake.
…new-window-develop Fix the "Open in new window" checkbox behavior for the problem editor (for develop).
access control allow origin from webwork2_files
OPLUpdate now needs to be run via OPLUpdate #Default update of OPL OPLUpdate LIBNAME [noDrop] #specific libname and optional argument
the commit 4a04d9c introduced IIFE in setmaker.
taniwallach
pushed a commit
that referenced
this pull request
Nov 21, 2024
Implement suggestions made in my review of openwebwork#2266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged most recent version of
devand tried to get it to work again.Issues
1
Happens if Library is
All Librariesand one tries to selectSubject,ChapterorSection2
No matching problems if no subject is selected
3
Get subjects in this library button not working directly. Only after "View Problems" has been clicked
View Problems causes furthermore other issues.
4
Clicking on View Problems fills
Subject,ChaperandSectionsindependent of previous selection5
Browse OPL Directory Problems
6
Number of WeBWorK problems not updated, if Library selection changes. Same for click on "Get subjects in this library"