Fixing some achievements (third_time, persistence, super_persistence) #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Jordan
reviewed
Apr 16, 2021
drdrew42
approved these changes
Apr 16, 2021
|
Ugg. So I wasn't paying attention and I see that I merged this into |
|
I will take care of it. |
|
I will presume that all are intended for the release. |
|
At least of the ones just merged that is. |
|
imho they should all go into the release. They fix things that were not working as they should have been. And they are so small scale that there's no need for more testing. |
|
Yeah, the two branches are synchronized now. |
|
Thanks. I remembered to change to |
|
Thank you for including to 2.16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for three achievements. They do not work as advertised. Without this fix it would be possible to earn achievement "Solve a problem on the third submission" by entering correct answer followed by two incorrect answers to the same question. Similarly for other two achievements.
This should be installed after #1319