Merge pull request #1324 from robert-marik/thirdTime

Fixing some achievements (third_time, persistence, super_persistence)
openwebwork · Apr 16, 2021 · 817a19f · 817a19f
2 parents 374de41 + 4c5fc05
commit 817a19f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/courses.dist/modelCourse/templates/achievements/persistance.at b/courses.dist/modelCourse/templates/achievements/persistance.at
@@ -1,7 +1,7 @@
 #This checks to see if the student has solved the problem after a certain
 # number of incorrect attempts
 
-     if ($problem->status == 1 && $problem->num_incorrect >= 20) {
+     if ($problem->status == 1 && $problem->num_correct == 1 && $problem->num_incorrect >= 20) {
 	return 1
      }    else {
 	return 0;

diff --git a/courses.dist/modelCourse/templates/achievements/super_persistance.at b/courses.dist/modelCourse/templates/achievements/super_persistance.at
@@ -1,7 +1,7 @@
 #This checks to see if the student has solved the problem after a certain
 # number of incorrect attempts
 
-     if ($problem->status == 1 && $problem->num_incorrect >= 100) {
+     if ($problem->status == 1 && $problem->num_correct == 1 && $problem->num_incorrect >= 100) {
 	return 1
      }    else {
 	return 0;

diff --git a/courses.dist/modelCourse/templates/achievements/third_time.at b/courses.dist/modelCourse/templates/achievements/third_time.at
@@ -1,6 +1,6 @@
 #This checks to see if the student has a certain number of attempts
 
-    if ($problem->num_correct == 1 and $problem->num_incorrect == 2) {
+    if ($problem->num_correct == 1 and $problem->num_incorrect == 2 and $problem->status == 1) {
 	return 1;
     }    else {
 	return 0;