Skip to content

Commit

Permalink
Update patch set 5
Browse files Browse the repository at this point in the history
Patch Set 5: Code-Review+2 Workflow+1

> > Looks like pymemcache does not support the binary protocol, so
 > does
 > > not support sasl.  (there's another issue for missing ipv6
 > support)
 > >
 > > pinterest/pymemcache#54
 > >
 > > looks like this is required for sasl support, sadly  In
 > > global-requirements, do you mind adding a comment above the entry
 > > stating that it is only required for sasl/binary protocol (so
 > that
 > > it can be cleaned up if/when sasl/binary protocol is merged into
 > > another 'approved' library).
 > 
 > I think this is the best option we can think for the current
 > situation.

I agree too

Patch-set: 5
Reviewer: Gerrit User 28522 <28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
Label: Workflow=+1
  • Loading branch information
Gerrit User 28522 authored and openstack-gerrit committed Jul 27, 2020
1 parent d89d105 commit 5f90a31
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 5f90a31

Please sign in to comment.