-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the binary protocol #54
Comments
In addition to being faster, the binary protocol is required if using SASL auth (eg with a cloud memcached offering such as Memcachier or Memcached Cloud). Both pylibmc and python-binary-memcached support the binary protocol, and thus SASL auth. |
I was actually looking at this just the other day. I'll need to spend some time on it, but I think this would be a nice feature to add. |
We use mcrouter extensively at Pinterest, and it unfortunately doesn't support the binary protocol (facebook/mcrouter#6). That makes it less of a priority for us (internal-development-wise), but we'd be happy to accept a patch! |
Hey there, just noting that some of your links in this thread are broken (e.g. https://code.google.com/p/memcached/wiki/MemcacheBinaryProtocol in @sontek 's post and @jparise 's mcrouter link) |
@simonzheng: I fixed my link. Thanks! |
I can fix mine tonight |
While it's probably still worth implementing for folks who do use it, the Binary protocol is actually deprecated in favor to the new Meta protocol https://github.com/memcached/memcached/wiki/ReleaseNotes160 |
Will this ever be revisited? |
➕ for this feature |
Patch Set 4: Looks like pymemcache does not support the binary protocol, so does not support sasl. (there's another issue for missing ipv6 support) pinterest/pymemcache#54 looks like this is required for sasl support, sadly In global-requirements, do you mind adding a comment above the entry stating that it is only required for sasl/binary protocol (so that it can be cleaned up if/when sasl/binary protocol is merged into another 'approved' library). Patch-set: 4
Patch Set 4: > Looks like pymemcache does not support the binary protocol, so does > not support sasl. (there's another issue for missing ipv6 support) > > pinterest/pymemcache#54 > > looks like this is required for sasl support, sadly In > global-requirements, do you mind adding a comment above the entry > stating that it is only required for sasl/binary protocol (so that > it can be cleaned up if/when sasl/binary protocol is merged into > another 'approved' library). I think this is the best option we can think for the current situation. Patch-set: 4 Reviewer: Gerrit User 31827 <31827@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
Patch Set 5: Code-Review+2 Workflow+1 > > Looks like pymemcache does not support the binary protocol, so > does > > not support sasl. (there's another issue for missing ipv6 > support) > > > > pinterest/pymemcache#54 > > > > looks like this is required for sasl support, sadly In > > global-requirements, do you mind adding a comment above the entry > > stating that it is only required for sasl/binary protocol (so > that > > it can be cleaned up if/when sasl/binary protocol is merged into > > another 'approved' library). > > I think this is the best option we can think for the current > situation. I agree too Patch-set: 5 Reviewer: Gerrit User 28522 <28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+2 Label: Workflow=+1
https://github.com/memcached/memcached/wiki/BinaryProtocolRevamped
The binary protocol is much faster than the text protocol:
http://www.erikwebb.net/blog/benchmarking-memcached-memslap/
pylibmc already supports this with
binary=True
Outside of performance this also allows
set_multi
to be a real performant call instead of a ton of individual calls.The text was updated successfully, but these errors were encountered: