Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/feat rewrite action and add new commands #245

Merged
merged 18 commits into from
Oct 19, 2024

Conversation

takanome-dev
Copy link
Owner

@takanome-dev takanome-dev commented Oct 14, 2024

What type of PR is this? (check all applicable)

  • πŸ’‘ Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • ⏩ Revert

Description

This pr adds new commands to the action.

Features

  • /assign @<user> & /unassign @<user> commands used by maintainers to assign and unassign issues to contributors
  • /assign-me & /unassign-me commands are for contributors wanting to take on an issue
  • post a comment if the commenter shows interest in contributing

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

@koppor
Copy link
Contributor

koppor commented Oct 16, 2024

I tested the branch.

Output of GitHub:

The following actions use a deprecated Node.js version and will be forced to run on node20: takanome-dev/assign-issue-action@refactor-rewrite-action. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The new placeholders don't seem to work:

image

Note that you will be unassigned if it isn't closed within **{{ total_days }} days** (**{{ unassigned_date }}**)
A maintainer can also add the **{{ pin_label }}** label to prevent it from being unassigned automatically.

(JabRef/jabref#11984 (comment))

@koppor
Copy link
Contributor

koppor commented Oct 16, 2024

Oh, the action assigned me 🀣

image

@koppor
Copy link
Contributor

koppor commented Oct 16, 2024

Action always adds a comment - even if no assign command is used:

image

JabRef/jabref#11984 (comment)

@takanome-dev
Copy link
Owner Author

I failed making it work on the first try 🀣🀣 Well, thanks for testing this out.

I still have failing tests that needs to be fixed that's why I haven't tested this yet on my test-action-repo.

Will try to make it work tomorrow morning πŸ™ƒ

@koppor
Copy link
Contributor

koppor commented Oct 18, 2024

Tested 5631f93 (#245)

  • βœ… assignment works
    -❌ placeholder in comment are not replaced
  • βœ… output was yes

image

@takanome-dev
Copy link
Owner Author

It will work if this pr is merged and I'm working on it. Just needs to do some final testing and update the readme

@koppor
Copy link
Contributor

koppor commented Oct 19, 2024

It will work if this pr is merged and I'm working on it. Just needs to do some final testing and update the readme

I am just impatient πŸ˜…πŸ€£πŸ€£

@takanome-dev takanome-dev marked this pull request as ready for review October 19, 2024 09:39
@takanome-dev takanome-dev merged commit cc6c349 into beta Oct 19, 2024
@takanome-dev takanome-dev deleted the refactor-rewrite-action branch October 19, 2024 09:50
@takanome-dev
Copy link
Owner Author

Thanks so much @koppor for all the issues you opened this week and for your patience throughout the process. Your detailed descriptions were incredibly helpful! It made me really happy to work on this again after 2 years 😊

If you encounter any more issues or have ideas for new features within the action, don’t hesitate to open more issues. Your contributions are greatly appreciated! πŸ™Œ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants