Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add /assign-previous-commenter #240

Closed
2 tasks done
koppor opened this issue Oct 13, 2024 · 4 comments · Fixed by #245
Closed
2 tasks done

Feature: Add /assign-previous-commenter #240

koppor opened this issue Oct 13, 2024 · 4 comments · Fixed by #245

Comments

@koppor
Copy link
Contributor

koppor commented Oct 13, 2024

Type of feature

💡 Feature

Current behavior

Contributor posts texts, because they is not aware of /assign-me:

image

There is no possiblity to comment something to have this magic of assignment (and unassignent aftter a timeout) working.

Suggested solution

Add /assign-previous-commenter which triggers the assignment of the previous (!) comment.

Advanced version could be /assign {url to issue comment}

Example:

/assign https://github.com/JabRef/jabref/issues/10418#issuecomment-2401128647

This would then assign the poster of that comment to the current issue.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@koppor
Copy link
Contributor Author

koppor commented Oct 16, 2024

Maybe /assign-last-commenter is the better name - to have a clear indication who is meant.

@koppor koppor changed the title Feature: Add /assign-commenter Feature: Add /assign-last-commenter Oct 16, 2024
@koppor koppor changed the title Feature: Add /assign-last-commenter Feature: Add /assign-previous-commenter Oct 16, 2024
@koppor
Copy link
Contributor Author

koppor commented Oct 16, 2024

OK, previous might be even better ^^

@takanome-dev
Copy link
Owner

I’ve opted for /assign @<username> (still in draft and untested) instead of /assign-previous.

The reason is simple:

  • If two people comment on the same issue and you want to assign it to the first person, /assign-previous would assign it to the last commenter, which may not be what you intend.

Using the username directly gives more control. Thoughts?

@koppor
Copy link
Contributor Author

koppor commented Oct 16, 2024

Using the username directly gives more control. Thoughts?

Very nice idea! I just didn't see this option 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants