Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opengl] Tolerate all errors in with_opengl() #884

Merged
merged 3 commits into from
Apr 27, 2020
Merged

[opengl] Tolerate all errors in with_opengl() #884

merged 3 commits into from
Apr 27, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate requested a review from yuanming-hu April 27, 2020 03:24
yuanming-hu
yuanming-hu approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please merge after CI passes. Let's see if the Linux buildbot is happy now. Hopefully we can release v0.5.15 before I go to sleep today.

@archibate
Copy link
Collaborator Author

Btw, why not just bump to v0.6 for OpenGL?

@archibate archibate changed the title [opengl] tolerate all errors in with_opengl() [opengl] Tolerate all errors in with_opengl() Apr 27, 2020
@yuanming-hu
Copy link
Member

Btw, why not just bump to v0.6 for OpenGL?

Once a version is released it's hard to erase. We'd better have v0.5.15 as a test. Maybe OpenGL will run into some issue when shipped as a PyPI package.

@archibate archibate merged commit 7b85ffe into taichi-dev:master Apr 27, 2020
@archibate
Copy link
Collaborator Author

archibate commented Apr 27, 2020 •
edited
Loading

Let's also test the stable branch in v0.6.0 or v0.5.15 too, wdyt?
Btw, please don't mind AppVeyor failure, it's not failure, it's cancelled due to PR closed:

%PYTHON% examples/laplace.py
[Taichi] mode=development
[Taichi] <dev mode>, supported archs: [cpu only], commit 4266f4dc, python 3.6.8
0.0
4.0
0.0
0.0
4.0
0.0
0.0
4.0
0.0
0.0

Did works well!

@yuanming-hu
Copy link
Member

Thanks for taking care of this! I mean, we should pretend we are the end-users and test the release mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archibate @yuanming-hu