Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opengl] Detect driver existance in with_opengl() #864

Merged
merged 2 commits into from
Apr 26, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate commented Apr 25, 2020

Related issue = #664

As you mentioned in #843 (comment).

We're on the edge of v0.6!
In this PR, I do initialize_opengl in with_opengl so that we can detect if driver available, and compute shaders are supported.

[Click here for the format server]

@archibate archibate requested a review from yuanming-hu April 25, 2020 02:42
@archibate archibate linked an issue Apr 25, 2020 that may be closed by this pull request
@archibate archibate changed the title [opengl] detect driver existance in with_opengl() [opengl] Detect driver existance in with_opengl() Apr 25, 2020
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this. Please do not request a review until CI passes and you have proof-read your code 3-5 times. Otherwise, the reviewer's time will likely be wasted. (I follow this rule as well.)

taichi/backends/opengl/opengl_api.cpp Outdated Show resolved Hide resolved
@archibate archibate requested a review from yuanming-hu April 25, 2020 04:22
why doesn't appveyor restart?

fix non-GL
@archibate
Copy link
Collaborator Author

Why is Travis still running from yesterday to today...how slow it is...

@yuanming-hu
Copy link
Member

Why is Travis still running from yesterday to today...how slow it is...

I triggered a re-build just now - let's see if it passes now :-)

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! I'll release v0.5.15 with OpenGL now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OpenGL] Ship OpenGL backend
2 participants