-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opengl] Detect driver existance in with_opengl() #864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this. Please do not request a review until CI passes and you have proof-read your code 3-5 times. Otherwise, the reviewer's time will likely be wasted. (I follow this rule as well.)
rid appveyor
Why is Travis still running from yesterday to today...how slow it is... |
I triggered a re-build just now - let's see if it passes now :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! I'll release v0.5.15 with OpenGL now.
Related issue = #664
As you mentioned in #843 (comment).
We're on the edge of v0.6!
In this PR, I do
initialize_opengl
inwith_opengl
so that we can detect if driver available, and compute shaders are supported.[Click here for the format server]