[bug] Fix crashing on printing FrontendFuncCallStmt with no return value #7561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Mar 14, 2023
lin-hitonami
requested review from
ailzhang,
bobcao3,
jim19930609 and
strongoier
jim19930609
approved these changes
Mar 15, 2023
|
/land |
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
ghstack-source-id: ea9ce89c135c501d59ba85fe954d1352a84a1671 Pull Request resolved: taichi-dev#7561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taichi crashes when printing FrontendFuncCallStmt with no return value because
stmt->ident(which is the identifier of its return value) is null when it does not have a return value. This PR fixes this bug.Stack from ghstack (oldest at bottom):