New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Migrate {set, get}_{arg, ret} functions from RuntimeContext to LaunchContextBuilder #7550

Closed

lin-hitonami wants to merge 13 commits into gh/lin-hitonami/9/base from gh/lin-hitonami/9/head

Contributor

lin-hitonami commented Mar 14, 2023 •

edited

Loading

Will delete the functions in RuntimeContext in future PRs.

Stack from ghstack (oldest at bottom):


          [refactor] Let LaunchContextBuilder be the argument of the compiled k…

75e131b

…ernel function on host

[ghstack-poisoned]

This was referenced Mar 14, 2023

[ir] Let the reference type declare a pointer argument #7546

Merged

[aot] Let C-API use LaunchContextBuilder to manage RuntimeContext #7547

Merged

[ir] Let void struct type represent void type #7548

Closed

[llvm] Compile the kernel arguments to a StructType #7441

Closed

lin-hitonami added a commit that referenced this pull request


          [refactor] Let LaunchContextBuilder be the argument of the compiled k…

5bd9fe9

…ernel function on host

ghstack-source-id: 1676d2afe31d5130e1c3e481c6cfd64dd900cfab
Pull Request resolved: #7550

lin-hitonami marked this pull request as draft

March 14, 2023 05:19


          Update on "[refactor] Let LaunchContextBuilder be the argument of the…

b703f70

… compiled kernel function on host"

[ghstack-poisoned]

lin-hitonami mentioned this pull request

[llvm] Generalize TaskCodeGenLLVM::create_return to set_struct_to_buffer #7558

Closed

lin-hitonami added a commit that referenced this pull request


          [refactor] Let LaunchContextBuilder be the argument of the compiled k…

ad0dea7

…ernel function on host

ghstack-source-id: 5230e6aee5f4eed5f849e2a9cb1df5b87e273ef1
Pull Request resolved: #7550


          Update on "[refactor] Let LaunchContextBuilder be the argument of the…

41aa60d

… compiled kernel function on host"

[ghstack-poisoned]

lin-hitonami added a commit that referenced this pull request


          [refactor] Let LaunchContextBuilder be the argument of the compiled k…

d872540

…ernel function on host

ghstack-source-id: f01a219b4e23dba2ce1cdb058a330ae70ae58c0d
Pull Request resolved: #7550


          Update on "[refactor] Let LaunchContextBuilder be the argument of the…

95af55d

… compiled kernel function on host"

[ghstack-poisoned]

lin-hitonami mentioned this pull request

[refactor] Remove LaunchContextBuilder::set_arg_raw #7560

Closed

lin-hitonami added a commit that referenced this pull request


          [refactor] Let LaunchContextBuilder be the argument of the compiled k…

af02304

…ernel function on host

ghstack-source-id: f98d8749890464dcbd2941f1a19ea1a34532f110
Pull Request resolved: #7550


          Update on "[refactor] Let LaunchContextBuilder be the argument of the…

bd72d78

… compiled kernel function on host"

[ghstack-poisoned]

lin-hitonami mentioned this pull request

[bug] Fix crashing on printing FrontendFuncCallStmt with no return value #7561

Closed

lin-hitonami added a commit that referenced this pull request


          [refactor] Let LaunchContextBuilder be the argument of the compiled k…

3b421ea

…ernel function on host

ghstack-source-id: e1e08fac63499039788a347e03d8191b9d38c0c4
Pull Request resolved: #7550


          Update on "[refactor] Let LaunchContextBuilder be the argument of the…

a84e522

… compiled kernel function on host"

[ghstack-poisoned]

lin-hitonami added a commit that referenced this pull request


          [refactor] Let LaunchContextBuilder be the argument of the compiled k…

039eae0

…ernel function on host

ghstack-source-id: e80a5a80e1af97ddffcfdc39d03869e858e84903
Pull Request resolved: #7550


          Update on "[refactor] Let LaunchContextBuilder be the argument of the…

66161d4

… compiled kernel function on host"

[ghstack-poisoned]

lin-hitonami added a commit that referenced this pull request


          [refactor] Let LaunchContextBuilder be the argument of the compiled k…

bb7b2d1

…ernel function on host

ghstack-source-id: b0449c66699cf667699fab8a1dba603b1b3caf99
Pull Request resolved: #7550


          Update on "[refactor] Let LaunchContextBuilder be the argument of the…

166d44e

… compiled kernel function on host"

[ghstack-poisoned]

lin-hitonami added a commit that referenced this pull request


          [refactor] Migrate {set, get}_{arg, ret} functions from RuntimeContext

60840cd

to LaunchContextBuilder

ghstack-source-id: 8deb110f444528d8da97dad4d2f6ba2c549b0db7
Pull Request resolved: #7550

lin-hitonami changed the title ~~[refactor] Let LaunchContextBuilder be the argument of the compiled kernel function on host~~ [refactor] Migrate {set, get}_{arg, ret} functions from RuntimeContext to LaunchContextBuilder


          Update on "[refactor] Migrate {set, get}_{arg, ret} functions from Ru…

d9b9f8a

…ntimeContext to LaunchContextBuilder"

[ghstack-poisoned]

lin-hitonami mentioned this pull request

[refactor] Let LaunchContextBuilder be the argument of the kernel launch function #7576

Merged

lin-hitonami added 2 commits

March 16, 2023 15:22


          Update on "[refactor] Migrate {set, get}_{arg, ret} functions from Ru…

5b23760

…ntimeContext to LaunchContextBuilder"

[ghstack-poisoned]


          Update on "[refactor] Migrate {set, get}_{arg, ret} functions from Ru…

38c4e81

…ntimeContext to LaunchContextBuilder"

[ghstack-poisoned]

lin-hitonami marked this pull request as ready for review

March 20, 2023 09:33

lin-hitonami requested review from ailzhang, bobcao3, jim19930609, PGZXB and PENGUINLIONG

March 20, 2023 09:36


          Update on "[refactor] Migrate {set, get}_{arg, ret} functions from Ru…

3957c14

…ntimeContext to LaunchContextBuilder"

Will delete the functions in `RuntimeContext` in future PRs.




[ghstack-poisoned]

lin-hitonami mentioned this pull request

[llvm] [refactor] Set the llvm runtime when executing #7601

Closed

PENGUINLIONG approved these changes

View reviewed changes

Member

PENGUINLIONG left a comment

thank you!

lin-hitonami mentioned this pull request

[gfx] [refactor] Let GfxRuntime use LaunchContextBuilder #7608

Merged


          Update on "[refactor] Migrate {set, get}_{arg, ret} functions from Ru…

78ccd38

…ntimeContext to LaunchContextBuilder"

Will delete the functions in `RuntimeContext` in future PRs.




[ghstack-poisoned]

This was referenced Mar 21, 2023

[aot] [refactor] Pass LaunchContextBuilder to CompiledGraph::init_runtime_context #7610

Merged

[refactor] Remove the get/set functions in RuntimeContext #7611

Merged

[refactor] Migrate members from RuntimeContext to LaunchContextBuilder #7612

Merged

taichi-gardener deleted the branch gh/lin-hitonami/9/base

March 21, 2023 08:50

taichi-gardener closed this in

f82242b

taichi-gardener closed this

taichi-gardener deleted the gh/lin-hitonami/9/head branch

March 21, 2023 08:50

quadpixels pushed a commit to quadpixels/taichi that referenced this pull request


          [refactor] Migrate {set, get}_{arg, ret} functions from RuntimeContext

e0b3aad

to LaunchContextBuilder

ghstack-source-id: b21aef43298ffef0a3251f6e0c2b3150e8acb34e
Pull Request resolved: taichi-dev#7550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

PENGUINLIONG PENGUINLIONG approved these changes

ailzhang Awaiting requested review from ailzhang

bobcao3 Awaiting requested review from bobcao3

jim19930609 Awaiting requested review from jim19930609

PGZXB Awaiting requested review from PGZXB

Labels

None yet