Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vulkan] Change command list submit error message & misc device API cleanups #7395

Merged
merged 2 commits into from
Feb 20, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
  • Loading branch information
pre-commit-ci[bot] committed Feb 18, 2023
commit dacfb01b57d3e4019ad75a9cafb056f290fa4aec
12 changes: 6 additions & 6 deletions taichi/rhi/vulkan/vulkan_device.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -417,8 +417,8 @@ void VulkanPipeline::create_pipeline_layout() {

void VulkanPipeline::create_compute_pipeline(const Params &params) {
std::array<char, 512> msg_buf;
RHI_DEBUG_SNPRINTF(msg_buf.data(), msg_buf.size(), "Compiling Vulkan pipeline %s",
params.name.data());
RHI_DEBUG_SNPRINTF(msg_buf.data(), msg_buf.size(),
"Compiling Vulkan pipeline %s", params.name.data());
RHI_LOG_DEBUG(msg_buf.data());
pipeline_ = vkapi::create_compute_pipeline(device_, 0, shader_stages_[0],
pipeline_layout_, params.cache);
Expand Down Expand Up @@ -942,8 +942,8 @@ RhiResult VulkanCommandList::bind_shader_resources(ShaderResourceSet *res,
for (const auto &binding : set->get_bindings()) {
std::array<char, 256> msg_buf;
RHI_DEBUG_SNPRINTF(msg_buf.data(), msg_buf.size(),
"Binding %d: (VkDescriptorType) %d",
binding.first, binding.second.type);
"Binding %d: (VkDescriptorType) %d", binding.first,
binding.second.type);
RHI_LOG_ERROR(msg_buf.data());
}

Expand Down Expand Up @@ -2677,8 +2677,8 @@ void VulkanSurface::create_swap_chain() {
{
std::array<char, 512> msg_buf;
RHI_DEBUG_SNPRINTF(msg_buf.data(), msg_buf.size(),
"Creating suface of %u x %u",
extent.width, extent.height);
"Creating suface of %u x %u", extent.width,
extent.height);
RHI_LOG_DEBUG(msg_buf.data());
}
VkImageUsageFlags usage =
Expand Down