[vulkan] Change command list submit error message & misc device API cleanups #7395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
for more information, see https://pre-commit.ci
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…leanups (taichi-dev#7395) ### Brief Summary The confusing "failed to submit command buffer" error message has been replaced with a device lost message (which is the typical type of failure that occurs when failing to submit cmdbuf). In addition, framebuffer caching code is removed, the reason not to do so is addressed in the comments. There are other misc changes / code quality changes included. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary
The confusing "failed to submit command buffer" error message has been replaced with a device lost message (which is the typical type of failure that occurs when failing to submit cmdbuf).
In addition, framebuffer caching code is removed, the reason not to do so is addressed in the comments. There are other misc changes / code quality changes included.