Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpu] Reuse VirtualMemoryAllocator for CPU ndarray memory allocation #7128

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

ailzhang
Copy link
Contributor

Fixes #7119

Brief Summary

It seems unnecessary for CPU to use runtime jit memory allocation for ndarray, let's see if anything breaks...

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 0efe10b
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63be9f577ebc0e00084b94e9

@ailzhang ailzhang marked this pull request as ready for review January 11, 2023 12:40
@ailzhang ailzhang added this to the v1.4.0 milestone Jan 12, 2023
Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lin-hitonami lin-hitonami merged commit d5eae11 into taichi-dev:master Jan 12, 2023
lin-hitonami pushed a commit that referenced this pull request Jan 12, 2023
…7128)

Fixes #7119

It seems unnecessary for CPU to use runtime jit memory allocation for
ndarray, let's see if anything breaks...
lin-hitonami pushed a commit that referenced this pull request Jan 12, 2023
…7128)

Fixes #7119

It seems unnecessary for CPU to use runtime jit memory allocation for
ndarray, let's see if anything breaks...
lin-hitonami pushed a commit that referenced this pull request Jan 12, 2023
…7128)

Fixes #7119

It seems unnecessary for CPU to use runtime jit memory allocation for
ndarray, let's see if anything breaks...
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
…aichi-dev#7128)

Fixes taichi-dev#7119

### Brief Summary
It seems unnecessary for CPU to use runtime jit memory allocation for
ndarray, let's see if anything breaks...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Ndarray on CPU are not handled by caching allocator
2 participants