Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Ndarray on CPU are not handled by caching allocator #7119

Closed
ailzhang opened this issue Jan 11, 2023 · 0 comments · Fixed by #7128
Closed

[bug] Ndarray on CPU are not handled by caching allocator #7119

ailzhang opened this issue Jan 11, 2023 · 0 comments · Fixed by #7128
Assignees
@ailzhang
Labels
bug We've confirmed that this is an BUG

Comments

@ailzhang
Copy link
Contributor

It's listed as TODO here https://github.com/taichi-dev/taichi/blob/master/taichi/rhi/cpu/cpu_device.cpp#L33.
Without this being implemented, ndarray will always allocate new memories instead of reusing freed cached memory blocks.
Found this in #7072
@ailzhang ailzhang added the bug We've confirmed that this is an BUG label Jan 11, 2023
@ailzhang ailzhang self-assigned this Jan 11, 2023
@github-project-automation github-project-automation bot moved this to Untriaged in Taichi Lang Jan 11, 2023
@ailzhang ailzhang mentioned this issue Jan 11, 2023
Merged
ailzhang pushed a commit to ailzhang/taichi that referenced this issue Jan 11, 2023
[cpu] Reuse VirtualMemoryAllocator for CPU ndarray memory allocation
0efe10b 
Fixes taichi-dev#7119
@ailzhang ailzhang mentioned this issue Jan 11, 2023
Merged
lin-hitonami pushed a commit that referenced this issue Jan 12, 2023
@ailzhang
[cpu] Reuse VirtualMemoryAllocator for CPU ndarray memory allocation (#…
d5eae11 
…7128)

Fixes #7119

### Brief Summary
It seems unnecessary for CPU to use runtime jit memory allocation for
ndarray, let's see if anything breaks...
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Taichi Lang Jan 12, 2023
lin-hitonami pushed a commit that referenced this issue Jan 12, 2023
@ailzhang @lin-hitonami
[cpu] Reuse VirtualMemoryAllocator for CPU ndarray memory allocation (#…
5112943 
…7128)

Fixes #7119

It seems unnecessary for CPU to use runtime jit memory allocation for
ndarray, let's see if anything breaks...
lin-hitonami pushed a commit that referenced this issue Jan 12, 2023
@ailzhang @lin-hitonami
[cpu] Reuse VirtualMemoryAllocator for CPU ndarray memory allocation (#…
580dcab 
…7128)

Fixes #7119

It seems unnecessary for CPU to use runtime jit memory allocation for
ndarray, let's see if anything breaks...
lin-hitonami pushed a commit that referenced this issue Jan 12, 2023
@ailzhang @lin-hitonami
[cpu] Reuse VirtualMemoryAllocator for CPU ndarray memory allocation (#…
ba90eda 
…7128)

Fixes #7119

It seems unnecessary for CPU to use runtime jit memory allocation for
ndarray, let's see if anything breaks...
quadpixels pushed a commit to quadpixels/taichi that referenced this issue May 13, 2023
@ailzhang @quadpixels
[cpu] Reuse VirtualMemoryAllocator for CPU ndarray memory allocation (t…
574a809 
…aichi-dev#7128)

Fixes taichi-dev#7119

### Brief Summary
It seems unnecessary for CPU to use runtime jit memory allocation for
ndarray, let's see if anything breaks...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ailzhang ailzhang

Labels
bug We've confirmed that this is an BUG
Projects
Taichi Lang
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cpu] Reuse VirtualMemoryAllocator for CPU ndarray memory allocation ailzhang/taichi
1 participant
@ailzhang