[bug] Fix recompilation of filling a matrix field with the same matrix #6951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jim19930609
approved these changes
Dec 22, 2022
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
taichi-dev#6951) Issue: fix taichi-dev#6950 ### Brief Summary The change to `fill()` in taichi-dev#6892 (skips turning a `ti.Matrix` into a tuple) accidentally disallows compilation caching when the argument is a `ti.Matrix`, which causes taichi-dev#6950. This PR puts that behavior back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: fix #6950
Brief Summary
The change to
fill()in #6892 (skips turning ati.Matrixinto a tuple) accidentally disallows compilation caching when the argument is ati.Matrix, which causes #6950. This PR puts that behavior back.