Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Remove _TiScopeMatrixImpl #6892

Merged
merged 4 commits into from
Dec 14, 2022
Merged

[refactor] Remove _TiScopeMatrixImpl #6892

merged 4 commits into from
Dec 14, 2022

Conversation

strongoier
Copy link
Contributor

Issue: #5819

Brief Summary

Now the ti.Matrix class is only for Python-scope matrices.

@strongoier strongoier added the full-ci Run complete set of CI tests label Dec 13, 2022
@netlify
Copy link

netlify bot commented Dec 13, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 4eb01fc
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63983e651b5e3100086b2bc7
😎 Deploy Preview https://deploy-preview-6892--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@strongoier strongoier closed this Dec 13, 2022
@strongoier strongoier reopened this Dec 13, 2022
jim19930609
jim19930609 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@jim19930609 jim19930609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@strongoier strongoier merged commit acc2cb0 into taichi-dev:master Dec 14, 2022
@strongoier strongoier deleted the remove-ti-scope-matrix branch December 14, 2022 02:45
This was referenced Dec 21, 2022
Closed
Merged
strongoier added a commit that referenced this pull request Dec 22, 2022
@strongoier
[bug] Fix recompilation of filling a matrix field with the same matrix (
be15358 
#6951)

Issue: fix #6950

### Brief Summary

The change to `fill()` in #6892 (skips turning a `ti.Matrix` into a
tuple) accidentally disallows compilation caching when the argument is a
`ti.Matrix`, which causes #6950. This PR puts that behavior back.
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
@strongoier @pre-commit-ci @quadpixels
[refactor] Remove _TiScopeMatrixImpl (taichi-dev#6892)
c2e7292 
Issue: taichi-dev#5819

### Brief Summary

Now the `ti.Matrix` class is only for Python-scope matrices.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
@strongoier @quadpixels
[bug] Fix recompilation of filling a matrix field with the same matrix (
e18affc 
taichi-dev#6951)

Issue: fix taichi-dev#6950

### Brief Summary

The change to `fill()` in taichi-dev#6892 (skips turning a `ti.Matrix` into a
tuple) accidentally disallows compilation caching when the argument is a
`ti.Matrix`, which causes taichi-dev#6950. This PR puts that behavior back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim19930609 jim19930609 jim19930609 approved these changes

Assignees
No one assigned
Labels
full-ci Run complete set of CI tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strongoier @jim19930609