Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example] Add poission disk sampling example #6852

Merged
merged 3 commits into from
Dec 18, 2022
Merged

[example] Add poission disk sampling example #6852

merged 3 commits into from
Dec 18, 2022

Conversation

neozhaoliang
Copy link
Contributor

This PR adds the code in this repo: https://github.com/taichi-dev/poisson-sampling-homework to the example list

@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 675dd87
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/639e9d4de7db1c000891754f
😎 Deploy Preview https://deploy-preview-6852--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@neozhaoliang neozhaoliang requested a review from ailzhang December 9, 2022 07:53
Copy link
Contributor

@jim19930609 jim19930609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to run it on Linux? Doesn't seem to work on my local Linux machine:

image

@neozhaoliang
Copy link
Contributor Author

I got the same problem as you at first. Then I deleted my ticache folder and rebuilt taichi, it runs fine.

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will be nicer if you can add some comments to the code :D

python/taichi/examples/algorithm/poisson_disk_sampling.py Outdated Show resolved Hide resolved
python/taichi/examples/algorithm/poisson_disk_sampling.py Outdated Show resolved Hide resolved
python/taichi/examples/algorithm/poisson_disk_sampling.py Outdated Show resolved Hide resolved
@neozhaoliang neozhaoliang merged commit 6467159 into taichi-dev:master Dec 18, 2022
@neozhaoliang neozhaoliang deleted the add-poisson-sampling-example branch December 18, 2022 09:04
import taichi as ti
import taichi.math as tm

ti.init(arch=ti.gpu)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neozhaoliang these should be moved into main function as well.

quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
This PR adds the code in this repo:
https://github.com/taichi-dev/poisson-sampling-homework to the example
list

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants