[vulkan] Support printing in debug mode on vulkan backend #6075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ailzhang
force-pushed
the
spirv_print
branch
3 times, most recently
from
b17befb to
f4ee706
Compare
ailzhang
force-pushed
the
spirv_print
branch
from
f4ee706 to
513286d
Compare
ailzhang
added a commit
that referenced
this pull request
Sep 19, 2022
Issue: #6075 (followup) ### Brief Summary Rename debug_ segment to a more proper name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2713
This is a long waited debugging utils that we finally get it done. Note since debug printing requires validation layer support, you'll need to have Vulkan SDK installed on your system to use it properly. For example https://vulkan.lunarg.com/doc/sdk/1.3.224.1/linux/getting_started_ubuntu.html.
Also to enable debug printing on vulkan backend you'll need to make sure
ti.init(..., debug=True)so that we enable the validation layer properly.Nit: our test_print.py doesn't really validate the printed message but I've run them with
-v -sto verify the outputs visually.Note: validation layer is not available on molten-vk so vulkan printing on macos won't work.
TODO: