-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Automate release publishing #4428
Conversation
✔️ Deploy Preview for docsite-preview ready! 🔨 Explore the source changes: 1a488eb 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/622866973cd1bf000730567a 😎 Browse the preview: https://deploy-preview-4428--docsite-preview.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool! I have one question but lgtm in general
7c409fe
to
045dd4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! Thanks!
(btw have you tested this in test_actions repo? :P
One really useful followup is to trigger upload after all 18 jobs finishes (instead of right after each job finishes) just in case some failures are valid and we need to send a new patch.
045dd4b
to
1a488eb
Compare
Updated the workflow, now there is only one upload step that uploads all built wheels at once.
Yeah, but it is still ongoing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Now that we've released 0.9.1 I guess it's safe to merge this PR. cc next release oncall @Leonz5288 just in case.
@frostming any idea why last night's |
@qiao-bo Because the first step is skipped which is the dependency of all subsequent jobs. I will submit a fix soon. |
@frostming seems another problem here on last night's build ;/ (https://github.com/taichi-dev/taichi/runs/5504453927?check_suite_focus=true). Here taichi/.github/workflows/release.yml Line 88 in 570c39d
|
@qiao-bo It seems the problem exists before, the line 89 is interpreted as:
I am suprised that |
this is indeed a bit mysterious ;/ |
Fix #1674
Changed the workflow for publishing releases, to be more automated. Details as below:
version.txt
in the project root as the single source of truth of the taichi version.workflow_dispatch
event, withversion
as the required input. It is similar to the following screenshot:version.txt
version.txt
content will be updated to the next patch version by the workflow, a PR will be created for the change. For example:inputs.version: 0.9.0
version.txt updated to : 0.9.1