Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Automatic version releases #1674

Closed
yuanming-hu opened this issue Aug 9, 2020 · 2 comments · Fixed by #4428
Closed

[Workflow] Automatic version releases #1674

yuanming-hu opened this issue Aug 9, 2020 · 2 comments · Fixed by #4428
Assignees
Labels
feature request Suggest an idea on this project welcome contribution

Comments

@yuanming-hu
Copy link
Member

Concisely describe the proposed feature

The current version release workflow is mostly manual. It would be great to make it more automatic.

Describe the solution you'd like (if any)

I briefly investigated the ways to do the workflow more automatically. The key is to make use of the RESTful GitHub API. For example,

First step

Maybe the initial step is to implement a CLI system that creates a release PR automatically.
Based on https://github.com/taichi-dev/taichi/blob/master/misc/format_server.py, we can perhaps we can create a "release server" that triggers releases twice a week.

Additional comments

Note that git request-pull is unrelated to opening a PR on GitHub: https://stackoverflow.com/questions/34945947/git-request-pull-how-to-create-a-github-pull-request-on-the-command-line

More investigation is needed to automatically trigger the CUDA build bot.

@archibate
Copy link
Collaborator

The key is to make use of the RESTful GitHub API.

That would be helpful when releasing from CLI.
Alternative solution is to release via the official GitHub Action https://github.com/actions/create-release.

Would you mind provide more information about how PyPI packages currently? It's heard that you have a PyPI automation rule that detects GitHub release?

@yuanming-hu
Copy link
Member Author

Alternative solution is to release via the official GitHub Action https://github.com/actions/create-release.

Oh, that one looks nice! Is there a way to trigger it after the release PR is merged? (Something like post-commit action?)

Would you mind provide more information about how PyPI packages currently? It's heard that you have a PyPI automation rule that detects GitHub release?

So basically every buildbot will try to upload. However, only the post-commit build bot has access to the PyPI password, so the pre-commit build will automatically fail to upload.

The other fact is that PyPI will just keep the first upload of a version, that's why only the release PR commit gets uploaded and later post-commit builds will fail to upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Suggest an idea on this project welcome contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants