-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Move c_quoted into taichi/utils/ #1376
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1376 +/- ##
==========================================
- Coverage 85.65% 85.60% -0.06%
==========================================
Files 19 19
Lines 3373 3375 +2
Branches 624 625 +1
==========================================
Hits 2889 2889
- Misses 354 356 +2
Partials 130 130
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiling & running happily on my end! Thanks!
Btw, would you help me set up C backend on OS X after #1354 gets merged?
But, how about to move this to |
Is there any evidence this might hurt compilation time? I'd suggest to keep |
Sure. I just did a local test with C backend enabled. Didn't encounter compilation error at least... |
Sounds reasonable, thank for the hard work!
Would you run ti.init(ti.cc)
@ti.kernel
def hello():
print('Hello, world!')
hello() to confirm? TTYM in the C backend issue. Let's merge this for now. |
Moving this to a common utils so that IR printer can also use it.
@archibate I don't have a way to test the C backend on Mac. Could you confirm this doesn't break?
Related issue = #1350 (comment)
[Click here for the format server]