Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cc] Add struct compiler to the experimental C backend #1354

Merged
merged 7 commits into from
Jul 4, 2020
Merged

[cc] Add struct compiler to the experimental C backend #1354

merged 7 commits into from
Jul 4, 2020

Conversation

archibate
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Jun 29, 2020 •
edited
Loading

Codecov Report

Merging #1354 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1354   +/-   ##
=======================================
  Coverage   66.72%   66.72%           
=======================================
  Files          37       37           
  Lines        5196     5196           
  Branches      933      933           
=======================================
  Hits         3467     3467           
  Misses       1567     1567           
  Partials      162      162

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe17ca1...56d8297. Read the comment docs.

@archibate archibate marked this pull request as draft June 29, 2020 02:24
@archibate archibate mentioned this pull request Jun 30, 2020
Merged
@archibate archibate marked this pull request as ready for review June 30, 2020 13:57
@archibate archibate requested a review from xumingkuan June 30, 2020 14:45
@k-ye k-ye mentioned this pull request Jul 2, 2020
Merged
@archibate
Copy link
Collaborator Author

Hello? Given this part is only used by me for now, may I merge this as soon as CI pass so I could go forward?

@archibate archibate mentioned this pull request Jul 4, 2020
Merged
yuanming-hu
yuanming-hu approved these changes Jul 4, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about my delayed reply. Yes, please feel free to merge. I trust your implementation.

@archibate archibate merged commit f2bd982 into taichi-dev:master Jul 4, 2020
@FantasyVR FantasyVR mentioned this pull request Jul 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu approved these changes

@k-ye k-ye Awaiting requested review from k-ye

@taichi-gardener taichi-gardener Awaiting requested review from taichi-gardener

@xumingkuan xumingkuan Awaiting requested review from xumingkuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archibate @yuanming-hu @taichi-gardener