[Refactor] [lang] Deprecate x.data_type() and use x.dtype instead #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archibate
requested review from
yuanming-hu,
KLozes and
taichi-gardener
and removed request for
yuanming-hu,
KLozes and
taichi-gardener
|
Hello? I want to refactor |
yuanming-hu
approved these changes
Jul 3, 2020
docs/meta.rst
Outdated
| @@ -17,55 +17,124 @@ Taichi kernels are *lazily instantiated* and a lot of computation can happen at | |||
| Template metaprogramming | |||
There was a problem hiding this comment.
I need to take a more careful pass on this part, which may take me a bit longer time. If you want to have this PR merged right now, could you move this file into a different PR? I'll take a look later. (Hopefully moving a single file isn't creating too much trouble for you... Sorry for being too busy these days...)
There was a problem hiding this comment.
Done, I'm super familiar with git revert these days, and may I merge this now?
Co-authored-by: Yuanming Hu <[email protected]>
This comment has been minimized.
This comment has been minimized.
archibate
changed the title
yuanming-hu
changed the title
Merged
archibate
added a commit
that referenced
this pull request
Jul 17, 2020
* [Refactor] [lang] x.data_type() is deprecated, use x.dtype instead * improve doc * did deprecate * fix * [skip ci] enforce code format * [skip ci] Update docs/vector.rst Co-authored-by: Yuanming Hu <[email protected]> * revert doc * Revert "revert doc" This reverts commit 0d3efb6. * [skip ci] Apply suggestions from code review Co-authored-by: Yuanming Hu <[email protected]> * [skip ci] Update docs/meta.rst Co-authored-by: Yuanming Hu <[email protected]> * Update docs/meta.rst Co-authored-by: Taichi Gardener <[email protected]> Co-authored-by: Yuanming Hu <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = close #1181
[Click here for the format server]