Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lang] [refactor] dt or dtype for data type? #1181

Closed
yuanming-hu opened this issue Jun 7, 2020 · 1 comment · Fixed by #1374
Closed

[Lang] [refactor] dt or dtype for data type? #1181

yuanming-hu opened this issue Jun 7, 2020 · 1 comment · Fixed by #1374
Labels
discussion Welcome discussion! good first issue A great chance for starters python Python engineering related welcome contribution

Comments

@yuanming-hu
Copy link
Member

Proposal

Currently we use dt for data type throughout the system. It may make sense to use dtype instead for consistency with numpy, TensorFlow and PyTorch.

Also, for simulation people dt may sounds like delta T (time step size).

I suggest that we deprecate dt and use dtype in future releases.

Inputs are welcome.
@yuanming-hu yuanming-hu added the discussion Welcome discussion! label Jun 7, 2020
@rexwangcc
Copy link
Collaborator

+1 to dtype to remove ambiguity.

@archibate archibate changed the title [RFC] [Lang] dt or dtype for data type? [Lang] [refactor] dt or dtype for data type? Jun 8, 2020
@archibate archibate added good first issue A great chance for starters python Python engineering related labels Jun 28, 2020
@archibate archibate mentioned this issue Jul 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Welcome discussion! good first issue A great chance for starters python Python engineering related welcome contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Refactor] [lang] Deprecate x.data_type() and use x.dtype instead archibate/taichi
3 participants
@yuanming-hu @rexwangcc @archibate