Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ir] Remove a temporary "fix_block_parents" #1352

Merged
merged 1 commit into from
Jul 4, 2020

Conversation

xumingkuan
Copy link
Contributor

@xumingkuan xumingkuan commented Jun 28, 2020

Related PR = #1285

I believe this is fixed in #1299. @yuanming-hu Could you please double-check if the demos work now which didn't work without the pass?

[Click here for the format server]


@xumingkuan xumingkuan requested a review from yuanming-hu June 28, 2020 23:11
@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #1352 into master will decrease coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
- Coverage   66.51%   66.40%   -0.11%     
==========================================
  Files          37       37              
  Lines        5149     5162      +13     
  Branches      932      933       +1     
==========================================
+ Hits         3425     3428       +3     
- Misses       1562     1572      +10     
  Partials      162      162              
Impacted Files Coverage Δ
python/taichi/misc/image.py 56.00% <47.36%> (-11.57%) ⬇️
python/taichi/__init__.py 91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c2a26...8726fba. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I confirm difftaichi examples still work.

@yuanming-hu yuanming-hu merged commit c4eda74 into taichi-dev:master Jul 4, 2020
@FantasyVR FantasyVR mentioned this pull request Jul 4, 2020
@xumingkuan xumingkuan deleted the block branch July 7, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants