[AutoDiff] Refactor AutoDiff system and support for loops that carry mutable states #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanming-hu
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1285 +/- ##
==========================================
- Coverage 85.09% 84.72% -0.37%
==========================================
Files 18 18
Lines 3273 3274 +1
Branches 616 616
==========================================
- Hits 2785 2774 -11
- Misses 352 365 +13
+ Partials 136 135 -1
Continue to review full report at Codecov.
|
xumingkuan
approved these changes
Jun 20, 2020
archibate
reviewed
Jun 20, 2020
Co-authored-by: xumingkuan <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #581 #1274
I confirmed that all the difftaichi demos works now.
@xumingkuan a high-level design document of the new autodiff system (which I cannot make public now) is emailed to you. Hope that will make reviewing easier.
[Click here for the format server]