-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lang] [refactor] Deprecate x.shape() and x.dim(), use x.shape instead #1318
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1318 +/- ##
==========================================
+ Coverage 85.48% 85.52% +0.04%
==========================================
Files 19 19
Lines 3375 3385 +10
Branches 630 630
==========================================
+ Hits 2885 2895 +10
Misses 358 358
Partials 132 132
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do you know if there are examples using shape()
or dim()
?
I |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks!
Will we make
data_type()
andsnode()
as a@property
as well?
Let's talk about it later. data_type
may be changed into dtype
: #1181.
Related issue = #1214 (comment)
[Click here for the format server]
dim()
.shape()
a@property
.mat.n
,mat.m
inmeta.rst
.Will we make
data_type()
andsnode()
as a@property
as well?