[ir] Set root block kernel after cloning #1245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've managed to fix all the
kernel == nullptr
problems that I've found so far. Note that this PR alone doesn't fix all the problems. In order to runmpm99
, you would still need to disable kernel fusion and constant folding. What's more interesting is that, the main constant folding workflow is fine, the problem was aroundtaichi/taichi/transforms/constant_fold.cpp
Lines 213 to 215 in 1402c4e
Honestly I think
IRNode::get_kernel()
is mostly broken in the async mode, since it depends on the assumption that root is a block..Related issue = #1243
[Click here for the format server]