Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ir] Set root block kernel after cloning #1245

Merged
merged 1 commit into from
Jun 15, 2020
Merged

[ir] Set root block kernel after cloning #1245

merged 1 commit into from
Jun 15, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Jun 14, 2020

I've managed to fix all the kernel == nullptr problems that I've found so far. Note that this PR alone doesn't fix all the problems. In order to run mpm99, you would still need to disable kernel fusion and constant folding. What's more interesting is that, the main constant folding workflow is fine, the problem was around

if (kernel && kernel->program.config.debug) {
TI_TRACE("config.debug enabled, ignoring constant fold");
return false;

Honestly I think IRNode::get_kernel() is mostly broken in the async mode, since it depends on the assumption that root is a block..

Related issue = #1243

[Click here for the format server]


@k-ye k-ye requested review from yuanming-hu and xumingkuan June 14, 2020 06:32
@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #1245 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1245   +/-   ##
=======================================
  Coverage   64.88%   64.88%           
=======================================
  Files          36       36           
  Lines        5041     5041           
  Branches      922      922           
=======================================
  Hits         3271     3271           
  Misses       1595     1595           
  Partials      175      175           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd9a14...c229f7c. Read the comment docs.

@archibate archibate self-requested a review June 14, 2020 09:31
Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but shall we modify the behavior in async mode so that the root is a Block containing an OffloadedStmt instead of a raw OffloadedStmt?

@k-ye
Copy link
Member Author

k-ye commented Jun 15, 2020

but shall we modify the behavior in async mode so that the root is a Block containing an OffloadedStmt instead of a raw OffloadedStmt?

Good point. I feel like this is a bit ad-hoc, but I cannot think of how this could break things in any other way.. Allow me to merge this one first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants