Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block::kernel isn't set correctly in the async computation #1243

Closed
2 tasks
k-ye opened this issue Jun 14, 2020 · 4 comments · Fixed by #1815
Closed
2 tasks

Block::kernel isn't set correctly in the async computation #1243

k-ye opened this issue Jun 14, 2020 · 4 comments · Fixed by #1815
Assignees
Labels
bug We've confirmed that this is an BUG c++ C++ engineering related

Comments

@k-ye
Copy link
Member

k-ye commented Jun 14, 2020

Describe the bug

Block::kernel isn't set correctly in the async computation. In the default mode, this works because the root block maps to a Taichi kernel, which has its kernel set. In the async mode, however, the root block maps to an offloaded task.

Other problems so far:

  • fuse need to respect memory barrier implicitly established by the kernel boundary.
  • constant folding??
@k-ye k-ye added bug We've confirmed that this is an BUG c++ C++ engineering related labels Jun 14, 2020
@k-ye k-ye self-assigned this Jun 14, 2020
@k-ye
Copy link
Member Author

k-ye commented Jun 15, 2020

One thing I forgot to mention: We should probably be a bit more careful when using default args, e.g.

void lower_access(IRNode *root, bool lower_atomic, Kernel *kernel = nullptr);

I feel like this has somehow complicated the code flow when debugging these things.

@xumingkuan
Copy link
Contributor

I wonder why we still need to pass these parameters given that we can get the Kernel * from an IRNode *...

@k-ye
Copy link
Member Author

k-ye commented Jun 16, 2020

I wonder why we still need to pass these parameters given that we can get the Kernel * from an IRNode *...

Well, this is probably added before we added IRNode::get_kernel()? But given that it's not working reliably...

@k-ye
Copy link
Member Author

k-ye commented Jun 17, 2020

This particular bug is fixed by #1245..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug We've confirmed that this is an BUG c++ C++ engineering related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants