Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #60 - Add ECK entities to RecentItems menu #61

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

colemanw
Copy link
Collaborator

@colemanw colemanw commented Oct 1, 2022

Fixes #60

@colemanw
Copy link
Collaborator Author

colemanw commented Oct 1, 2022

@jensschuppe this works in 5.53 but the edit link is incorrect. Not a blocker IMO but this fixes it: civicrm/civicrm-core#24662

CRM/Eck/DAO/Entity.php Show resolved Hide resolved
eck.php Outdated Show resolved Hide resolved
managed/OptionValue_eck_recent_items.mgd.php Show resolved Hide resolved
@jensschuppe jensschuppe merged commit adb97a8 into systopia:master Oct 24, 2022
@colemanw colemanw deleted the recentItems branch October 24, 2022 18:12
@jensschuppe jensschuppe added feature this issue represents a completely new feature status:fixed The issue has been resolved (usually by committing/merging code) labels Feb 8, 2023
@jensschuppe jensschuppe added this to the 1.0 milestone Feb 8, 2023
@colemanw
Copy link
Collaborator Author

@jensschuppe it would be helpful if you could merge civicrm/civicrm-core#24662

@colemanw
Copy link
Collaborator Author

colemanw commented Apr 8, 2023

Or rather, leave a review comment @jensschuppe and someone will merge it. Thanks!

@jensschuppe
Copy link
Collaborator

@colemanw Sorry this took so long, I successfully tested it with ECK's implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature this issue represents a completely new feature status:fixed The issue has been resolved (usually by committing/merging code)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ECK available in the *Recent items* menu
2 participants