Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecentItems - Improve automatic url construction #24662

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Oct 1, 2022

Overview

This improves the automatic construction of URLs to include tokens other than [id], which allows switching the CiviGrant extension to use the api. It also paves the way for the ECK extension to integrate with RecentItems.

@civibot
Copy link

civibot bot commented Oct 1, 2022

(Standard links)

@civibot civibot bot added the master label Oct 1, 2022
This improves the automatic construction of URLs to include tokens other than [id],
which allows switching the CiviGrant extension to use the api.
@colemanw
Copy link
Member Author

retest this please

Copy link
Contributor

@jensschuppe jensschuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with the ECK implementation and can confirm it correctly resolves "tokens" other than [id] in the paths.

@colemanw colemanw merged commit 0509d08 into civicrm:master Apr 11, 2023
@colemanw colemanw deleted the improveRecentApi branch April 11, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants