Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 test for server image list condition #996

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Conversation

aniruddha2000
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #943

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Copy link
Contributor

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to these tests that have to manually set the bootstrap condition? Why did you change something here?

@aniruddha2000 aniruddha2000 marked this pull request as ready for review October 4, 2023 15:36
@syself-bot syself-bot bot added the area/code Changes made in the code directory label Oct 4, 2023
@aniruddha2000 aniruddha2000 changed the title test for server image list condition 🌱 test for server image list condition Oct 4, 2023
controllers/hcloudmachine_controller_test.go Outdated Show resolved Hide resolved
pkg/services/hcloud/server/server.go Outdated Show resolved Hide resolved
@syself-bot syself-bot bot added the size/L Denotes a PR that changes 200-800 lines, ignoring generated files. label Oct 5, 2023
@aniruddha2000 aniruddha2000 marked this pull request as draft October 9, 2023 06:22
@aniruddha2000 aniruddha2000 marked this pull request as ready for review October 14, 2023 08:31
@aniruddha2000 aniruddha2000 merged commit 7a680ce into main Oct 14, 2023
13 checks passed
@aniruddha2000 aniruddha2000 deleted the ani/issues/943 branch October 14, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Changes made in the code directory size/L Denotes a PR that changes 200-800 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test whether conditions are set
2 participants