Add test for the condition

Signed-off-by: Aniruddha Basak <[email protected]>

controllers/hcloudmachine_controller_test.go

@@ -186,7 +186,7 @@ var _ = Describe("HCloudMachineReconciler", func() {
 				}, timeout).Should(BeTrue())
 			})
 
-			FIt("creates the HCloud machine in Hetzner", func() {
+			It("creates the HCloud machine in Hetzner", func() {
 				By("checking that no servers exist")
 
 				Eventually(func() bool {
@@ -254,6 +254,67 @@ var _ = Describe("HCloudMachineReconciler", func() {
 				}, timeout, time.Second).Should(BeTrue())
 			})
 		})
+
+		Context("correct server", func() {
+			BeforeEach(func() {
+				hcloudMachine.Spec.ImageName = "fedora-control-plane-2"
+
+				Expect(testEnv.Create(ctx, hcloudMachine)).To(Succeed())
+				Expect(testEnv.Create(ctx, hetznerCluster)).To(Succeed())
+			})
+
+			AfterEach(func() {
+				Expect(testEnv.Cleanup(ctx, hcloudMachine, hetznerCluster)).To(Succeed())
+			})
+
+			It("creates the HCloud machine in Hetzner", func() {
+				By("checking that no servers exist")
+
+				Eventually(func() bool {
+					servers, err := hcloudClient.ListServers(ctx, hcloud.ServerListOpts{
+						ListOpts: hcloud.ListOpts{
+							LabelSelector: utils.LabelsToLabelSelector(map[string]string{hetznerCluster.ClusterTagKey(): "owned"}),
+						},
+					})
+					if err != nil {
+						return false
+					}
+
+					return len(servers) == 0
+				}, timeout, time.Second).Should(BeTrue())
+
+				By("checking that bootstrap condition is not ready")
+
+				Eventually(func() bool {
+					return isPresentAndFalseWithReason(key, hcloudMachine, infrav1.BootstrapReadyCondition, infrav1.BootstrapNotReadyReason)
+				}, timeout, time.Second).Should(BeTrue())
+
+				By("setting the bootstrap data")
+
+				ph, err := patch.NewHelper(capiMachine, testEnv)
+				Expect(err).ShouldNot(HaveOccurred())
+
+				capiMachine.Spec.Bootstrap = clusterv1.Bootstrap{
+					DataSecretName: ptr.To("bootstrap-secret"),
+				}
+
+				Eventually(func() error {
+					return ph.Patch(ctx, capiMachine, patch.WithStatusObservedGeneration{})
+				}, timeout, time.Second).Should(BeNil())
+
+				By("checking that bootstrap condition is ready")
+
+				Eventually(func() bool {
+					return isPresentAndTrue(key, hcloudMachine, infrav1.BootstrapReadyCondition)
+				}, timeout, time.Second).Should(BeTrue())
+
+				By("checking HCloudMachine has ImageNotFoundReason")
+
+				Eventually(func() bool {
+					return isPresentAndFalseWithReason(key, hcloudMachine, infrav1.ServerCreateSucceededCondition, infrav1.ImageNotFoundReason)
+				}, timeout, time.Second).Should(BeTrue())
+			})
+		})
 	})
 
 	Context("various specs", func() {

pkg/services/hcloud/client/fake/hcloud_client.go

@@ -420,6 +420,10 @@ func (c *cacheHCloudClient) DeleteServiceFromLoadBalancer(_ context.Context, lb
 }
 
 func (c *cacheHCloudClient) ListImages(_ context.Context, opts hcloud.ImageListOpts) ([]*hcloud.Image, error) {
+	if opts.Name != "" {
+		return nil, nil
+	}
+
 	labels, err := utils.LabelSelectorToLabels(opts.LabelSelector)
 	if err != nil {
 		return nil, fmt.Errorf("failed to convert label selector to labels: %w", err)

pkg/services/hcloud/client/fake/hcloud_client_test.go

@@ -426,7 +426,7 @@ var _ = Describe("Load balancer", func() {
 		var listOpts hcloud.ImageListOpts
 		client := factory.NewClient("")
 		BeforeEach(func() {
-			listOpts.LabelSelector = labelSelector
+			listOpts.LabelSelector = "caph-image-name==fedora-control-plane"
 		})
 		It("lists at least one image", func() {
 			resp, err := client.ListImages(ctx, listOpts)