Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE Release 2024-12-02 #3427

Merged
merged 57 commits into from
Dec 2, 2024
Merged

FE Release 2024-12-02 #3427

merged 57 commits into from
Dec 2, 2024

Conversation

ChiTimesChi
Copy link
Collaborator

@ChiTimesChi ChiTimesChi commented Dec 2, 2024

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

767ab2e: docs preview link
767ab2e: explorer-ui preview link
767ab2e: synapse-interface preview link
a2328a5: docs preview link
a2328a5: explorer-ui preview link
a2328a5: synapse-interface preview link

parodime and others added 30 commits November 12, 2024 11:50
* add DepositAmount to QuoteInput, incorporate into getOriginAmount

* fix redundant declaration

* activequote tests. extended/revised comments

* lint

* relabel activeRFQ OriginAmount/DepositAmount to OriginAmountExact

* docs & json field label
* explorer UI updated

* rfq-indexer update

* explorer backend update

* [goreleaser] trigger explorer version bump

* rfq indexer with the right contracts

* [goreleaser] adding catch

* response error fixes and wld decimals

* adding address

* feat(rfq-indexer): add `request` column to `BridgeRequested` for refunds (#3287)

* feat(rfq-relayer): add MaxRelayAmount (#3259)

* Feat: add quoteParams helper for test

* Feat: add MaxQuoteAmount to relconfig

* Feat: use MaxQuoteAmount

* Feat: handle MaxQuoteAmount in quoter test

* Replace: MaxQuoteAmount -> MaxRelayAmount

* Feat: shouldProcess() returns false if max relay amount exceeded

* Feat: add test for MaxRelayAmount

* add request field for refunds

* adding to events typing

---------

Co-authored-by: dwasse <[email protected]>
Co-authored-by: defi-moses <[email protected]>

* fix api docs

* linting fixes

* fixing irrelavent files

* wc fixes and tests solved

* fix linting errors

* [goreleaser]

* refining tests

* adding bridge Module to graphql

* Adding to all bridge watcher queries

* adding worldchain to the chart

* adding other rfq events to the rfq events db

* fixing wld coingecko ticker [goreleaser]

* [goreleaser] coingecko update and new topic parsing

* small lint fix

* [goreleaser] linting fixes

* fix(rfq-indexer): add missing fields (#3309)

* add missing fields

---------

Co-authored-by: abtestingalpha <[email protected]>

---------

Co-authored-by: vro <[email protected]>
Co-authored-by: dwasse <[email protected]>
Co-authored-by: abtestingalpha <[email protected]>
* feat: start with identical AdminV2

* refactor: refund -> cancel

* test: update the tests, add coverage for deprecated method

* feat: scaffold `setCancelDelay`

* test: coverage for `calcelDelay` management

* feat: configurable cancel delay

* refactor: custom error `FeeRateAboveMax`

* test: chainGasAmount deprecation

* feat: deprecate `chainGasAmount`

* refactor: drop `UniversalTokenLib` in AdminV2

* refactor: event before external call, docs

* relabel RELAYER_ROLE -> PROVER_ROLE

* retain RELAYER_ROLE in addtn to PROVER_ROLE, for offchain perms

* refactor: RELAYER_ROLE -> QUOTER_ROLE, docs

* docs: AdminV2 other constants

---------

Co-authored-by: parodime <[email protected]>
* Feat: call filterQuoteAge() in handlePassiveRFQ()

* Feat: refactor into getPassiveQuote() func

* Feat: add TestGetPassiveQuote

* Config: lower max quote age
* fixing docs to reflect changes to endpoint and add more clarity

* language changes
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
* updating the bridge map

* remove WLD token constant

* fixing tests

---------

Co-authored-by: bigboydiamonds <[email protected]>
* add tx hash command

* [goreleaser]

* remove fake key

* add better logging

* fix context

* [goreleaser]
…59] (#3391)

* Feat: return success=false if dest amount is zero

* Feat: add getQuoteResponse helper

* Feat: add test for the no quotes case

* Cleanup: explicit checks for quote type

* Cleanup: comparisons
* feat: scaffold `ZapData` library

* test: define expected behavior for ZapDataV1

* feat: encoding, validation

* feat: decoding

* feat: scaffold `TokenZap`

* test: add coverage for TokenZap

* feat: expose encoding/decoding

* feat: implement `zap`

* fix: noAmount test, slight refactor

* test: scenarios where target contract reverts

* test: extra/missing funds scenarios

* refactor: TokenZap -> TokenZapV1

* test: FastBridgeV2 + TokenZapV1 integration

* fix: should revert when zero target in encoding

* chore: docs

* added target != addr 0 assumptions

* added one more target != addr 0 assumption

* refactor: relax ZapData pragma

* docs: improve grammar in ZapDataV1 comments

* test: adapt to #3382

* docs: NatSpec, fixing errors

---------

Co-authored-by: parodime <[email protected]>
* refactor: AdminV2 cleanup

* refactor: FastBridgeV2 comments styling

* refactor: struct assignment

* refactor: regroup functions

* docs: move to interfaces, fixing errors

* docs: final round of FastBridgeV2 comment changes

* docs: natspec

* nit

---------

Co-authored-by: parodime <[email protected]>
Copy link
Contributor

coderabbitai bot commented Dec 2, 2024

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

66 files out of 153 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

cloudflare-workers-and-pages bot commented Dec 2, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7a098e4
Status: ✅  Deploy successful!
Preview URL: https://75100a2b.sanguine-fe.pages.dev
Branch Preview URL: https://master.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Dec 2, 2024

Bundle Report

Changes will decrease total bundle size by 3.16MB (-8.86%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sdk-router-@synapsecns/sdk-router-esm* 255.26kB 609 bytes (0.24%) ⬆️
sdk-router-@synapsecns/sdk-router-cjs* 117.55kB 312 bytes (0.27%) ⬆️
explorer-ui-server-cjs* 724.31kB 141.75kB (-16.37%) ⬇️
explorer-ui-client-array-push* 2.17MB 146.63kB (-6.34%) ⬇️
synapse-interface-client-array-push* 7.41MB 132.56kB (1.82%) ⬆️
synapse-interface-server-cjs* 1.66MB 160.49kB (10.74%) ⬆️
widget-cjs-esm* 271.27kB 2.03kB (-0.74%) ⬇️
docs-bridge-client-array-push 7.46MB 438.56kB (-5.55%) ⬇️
docs-bridge-server-cjs 11.8MB 3.07MB (-20.66%) ⬇️
synapse-constants-esm-cjs* 174.63kB 174.63kB (100%) ⬆️
synapse-constants-cjs-esm* 174.18kB 174.18kB (100%) ⬆️

ℹ️ *Bundle size includes cached data from a previous commit

@ChiTimesChi ChiTimesChi merged commit acdd8d9 into fe-release Dec 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants