-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump dependencies #2848
bump dependencies #2848
Conversation
Warning Rate limit exceeded@trajan0x has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 44 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes primarily involve updating version dependencies across various GitHub Action workflows and project modules. Key updates include incrementing versions for actions like Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2848 +/- ##
===================================================
+ Coverage 25.36072% 25.36210% +0.00138%
===================================================
Files 783 783
Lines 56276 56269 -7
Branches 80 80
===================================================
- Hits 14272 14271 -1
+ Misses 40533 40525 -8
- Partials 1471 1473 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Updated dependencies in
agents/go.mod
to latest versions; ensure no breaking changes. - Removed 'origin_chainid' parameter in
contrib/opbot/botmd/commands.go
for 'refund' command; verify impact on refund processing. - Bumped
golang.org/x/mod
version incontrib/git-changes-action/go.mod
andgo.sum
. - Switched base image to
debian:12-slim
indocker/goreleaser/Dockerfile
; test for compatibility. - Updated dependencies in
contrib/opbot/go.mod
,core/go.mod
,ethergo/go.mod
, and other service modules; check for new features and bug fixes.
13 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
This reverts commit f66de2c.
Deploying sanguine-fe with
|
Latest commit: |
a41b903
|
Status: | ✅ Deploy successful! |
Preview URL: | https://77b052da.sanguine-fe.pages.dev |
Branch Preview URL: | https://fix-dep-bump.sanguine-fe.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Downgraded 'github.com/valyala/fasthttp' from v1.55.0 to v1.41.0 in
agents/go.mod
- Downgraded 'github.com/valyala/fasthttp' from v1.55.0 to v1.41.0 in
services/cctp-relayer/go.mod
- Downgraded 'github.com/valyala/fasthttp' from v1.55.0 to v1.41.0 in
services/omnirpc/go.mod
- Downgraded 'github.com/valyala/fasthttp' from v1.55.0 to v1.41.0 in
services/rfq/go.mod
- Downgraded 'github.com/valyala/fasthttp' from v1.55.0 to v1.41.0 in
services/scribe/go.mod
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (14)
agents/go.sum
is excluded by!**/*.sum
contrib/git-changes-action/go.sum
is excluded by!**/*.sum
contrib/opbot/go.sum
is excluded by!**/*.sum
contrib/promexporter/go.sum
is excluded by!**/*.sum
contrib/screener-api/go.sum
is excluded by!**/*.sum
core/go.sum
is excluded by!**/*.sum
ethergo/go.sum
is excluded by!**/*.sum
go.work.sum
is excluded by!**/*.sum
services/cctp-relayer/go.sum
is excluded by!**/*.sum
services/explorer/go.sum
is excluded by!**/*.sum
services/omnirpc/go.sum
is excluded by!**/*.sum
services/rfq/go.sum
is excluded by!**/*.sum
services/scribe/go.sum
is excluded by!**/*.sum
tools/go.sum
is excluded by!**/*.sum
Files selected for processing (23)
- .github/actions/add-label/action.yml (1 hunks)
- .github/actions/remove-label/action.yml (1 hunks)
- .github/workflows/close-stale.yml (1 hunks)
- .github/workflows/codeql.yaml (2 hunks)
- .github/workflows/go.yml (7 hunks)
- .github/workflows/goreleaser-actions.yml (1 hunks)
- .github/workflows/helm-test.yml (1 hunks)
- .github/workflows/labeler.yml (1 hunks)
- agents/go.mod (10 hunks)
- contrib/git-changes-action/go.mod (1 hunks)
- contrib/opbot/botmd/commands.go (2 hunks)
- contrib/opbot/go.mod (6 hunks)
- contrib/promexporter/go.mod (5 hunks)
- contrib/screener-api/go.mod (5 hunks)
- core/go.mod (4 hunks)
- docker/goreleaser/Dockerfile (1 hunks)
- ethergo/go.mod (7 hunks)
- services/cctp-relayer/go.mod (8 hunks)
- services/explorer/go.mod (5 hunks)
- services/omnirpc/go.mod (5 hunks)
- services/rfq/go.mod (8 hunks)
- services/scribe/go.mod (6 hunks)
- tools/go.mod (2 hunks)
Files skipped from review due to trivial changes (9)
- .github/actions/add-label/action.yml
- .github/actions/remove-label/action.yml
- .github/workflows/codeql.yaml
- .github/workflows/goreleaser-actions.yml
- .github/workflows/helm-test.yml
- .github/workflows/labeler.yml
- contrib/git-changes-action/go.mod
- docker/goreleaser/Dockerfile
- tools/go.mod
Additional comments not posted (79)
core/go.mod (6)
47-47
: Verify compatibility ofgo.opentelemetry.io/contrib/propagators/b3
v1.28.0.Ensure that the update from
v1.27.0
tov1.28.0
ofgo.opentelemetry.io/contrib/propagators/b3
is compatible and does not introduce breaking changes. Check the release notes for any significant changes.Verification successful
Verify compatibility of
go.opentelemetry.io/contrib/propagators/b3
v1.28.0.The update from
v1.27.0
tov1.28.0
ofgo.opentelemetry.io/contrib/propagators/b3
does not introduce any breaking changes. Instead, it includes a fix for an out-of-bounds panic related to invalid span IDs, which improves the stability of the package.
- No breaking changes were identified for
go.opentelemetry.io/contrib/propagators/b3
.- The update includes a critical fix for an out-of-bounds panic issue.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `go.opentelemetry.io/contrib/propagators/b3` v1.28.0. # Test: Check for breaking changes in the release notes. Expect: No breaking changes. curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go-contrib/releases | jq '.[].body' | grep -i "breaking"Length of output: 32653
50-50
: Verify compatibility ofgo.opentelemetry.io/otel/exporters/otlp/otlptrace
v1.28.0.Ensure that the update from
v1.27.0
tov1.28.0
ofgo.opentelemetry.io/otel/exporters/otlp/otlptrace
is compatible and does not introduce breaking changes. Check the release notes for any significant changes.Verification successful
Verified compatibility of
go.opentelemetry.io/otel/exporters/otlp/otlptrace
v1.28.0.The update from
v1.27.0
tov1.28.0
ofgo.opentelemetry.io/otel/exporters/otlp/otlptrace
does not introduce breaking changes and is compatible. The breaking changes mentioned in the release notes are related to new modules or other parts of the library, not directly tootlptrace
.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `go.opentelemetry.io/otel/exporters/otlp/otlptrace` v1.28.0. # Test: Check for breaking changes in the release notes. Expect: No breaking changes. curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases | jq '.[].body' | grep -i "breaking"Length of output: 10794
Script:
#!/bin/bash # Description: Verify specific breaking changes for `go.opentelemetry.io/otel/exporters/otlp/otlptrace` v1.28.0. # Test: Check for breaking changes in the `otlptrace` module release notes. Expect: No breaking changes. curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases | jq '.[] | select(.body | contains("otlptrace")) | .body' | grep -i "breaking"Length of output: 9288
52-52
: Verify compatibility ofgo.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp
v1.28.0.Ensure that the update from
v1.27.0
tov1.28.0
ofgo.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp
is compatible and does not introduce breaking changes. Check the release notes for any significant changes.Verification successful
The update from
v1.27.0
tov1.28.0
ofgo.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp
is verified to be compatible and does not introduce breaking changes.
- The changelog review for both versions confirms no breaking changes impacting
otlptracehttp
.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp` v1.28.0. # Test: Check for breaking changes in the release notes. Expect: No breaking changes. curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases | jq '.[].body' | grep -i "breaking"Length of output: 10794
Script:
#!/bin/bash # Description: Verify compatibility of `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp` v1.28.0 specifically. # Fetch the changelog for the versions between v1.27.0 and v1.28.0 curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases/tags/v1.28.0 | jq '.body' curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases/tags/v1.27.0 | jq '.body'Length of output: 39323
51-51
: Verify compatibility ofgo.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
v1.28.0.Ensure that the update from
v1.27.0
tov1.28.0
ofgo.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
is compatible and does not introduce breaking changes. Check the release notes for any significant changes.Verification successful
The dependency update from
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
v1.27.0 to v1.28.0 is compatible.The usage of
otlptracegrpc
incore/metrics/otlp.go
is not affected by the breaking changes mentioned in the release notes, as the breaking changes pertain to custom trace API implementations, which are not utilized in this context.
- File:
core/metrics/otlp.go
- Usage of
otlptracegrpc.NewClient()
is straightforward and does not involve custom trace API implementations.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc` v1.28.0. # Test: Check for breaking changes in the release notes. Expect: No breaking changes. curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases | jq '.[].body' | grep -i "breaking"Length of output: 10794
Script:
#!/bin/bash # Description: Search for the usage of `otlptracegrpc` in the codebase to verify the impact of breaking changes. # Find all occurrences of `otlptracegrpc` in the codebase. rg 'otlptracegrpc'Length of output: 4660
Script:
#!/bin/bash # Description: Review the implementation of `otlptracegrpc` usage in `core/metrics/otlp.go`. # Display the content of `core/metrics/otlp.go`. cat core/metrics/otlp.goLength of output: 2429
55-55
: Verify compatibility ofgo.opentelemetry.io/otel/metric
v1.28.0.Ensure that the update from
v1.27.0
tov1.28.0
ofgo.opentelemetry.io/otel/metric
is compatible and does not introduce breaking changes. Check the release notes for any significant changes.Verification successful
The update from
go.opentelemetry.io/otel/metric
v1.27.0 to v1.28.0 does not introduce breaking changes.The review of the release notes confirms that there are no breaking changes specifically related to the
go.opentelemetry.io/otel/metric
module in the updated version.
- The update is compatible and safe to proceed.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `go.opentelemetry.io/otel/metric` v1.28.0. # Test: Check for breaking changes in the release notes. Expect: No breaking changes. curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases | jq '.[].body' | grep -i "breaking"Length of output: 10794
Script:
#!/bin/bash # Description: Verify compatibility of `go.opentelemetry.io/otel/metric` v1.28.0. # Test: Check specifically for breaking changes related to `go.opentelemetry.io/otel/metric` in the release notes. curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases | jq '.[].body' | grep -i -A 5 "go.opentelemetry.io/otel/metric" | grep -i "breaking"Length of output: 10841
48-48
: Verify compatibility ofgo.opentelemetry.io/otel
v1.28.0.Ensure that the update from
v1.27.0
tov1.28.0
ofgo.opentelemetry.io/otel
is compatible and does not introduce breaking changes. Check the release notes for any significant changes.Verification successful
Check for custom implementations of
TracerProvider
,Tracer
, andSpan
interfaces.The update to
go.opentelemetry.io/otel
v1.28.0 includes breaking changes for custom trace API implementations. Verify if there are any custom implementations of theTracerProvider
,Tracer
, andSpan
interfaces in the codebase.
Verification successful for
go.opentelemetry.io/otel
v1.28.0 update.The update from
v1.27.0
tov1.28.0
ofgo.opentelemetry.io/otel
does not introduce breaking changes that impact the codebase, as no custom implementations of the affected interfaces were found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `go.opentelemetry.io/otel` v1.28.0. # Test: Check for breaking changes in the release notes. Expect: No breaking changes. curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases | jq '.[].body' | grep -i "breaking"Length of output: 10794
Script:
#!/bin/bash # Search for custom implementations of `TracerProvider`, `Tracer`, and `Span` interfaces in the codebase. # Find all Go files in the repository. files=$(fd --type f --extension go) # Search for implementations of `TracerProvider`, `Tracer`, and `Span` interfaces. for file in $files; do grep -H -E 'type.*(TracerProvider|Tracer|Span).*interface' "$file" doneLength of output: 272247
contrib/promexporter/go.mod (6)
38-38
: Dependency Update:go.opentelemetry.io/otel
tov1.28.0
The update appears to be consistent with other changes in the file.
39-39
: Dependency Update:go.opentelemetry.io/otel/metric
tov1.28.0
The update appears to be consistent with other changes in the file.
49-49
: Dependency Update:github.com/ClickHouse/clickhouse-go/v2
tov2.26.0
The update appears to be consistent with other changes in the file.
119-119
: Dependency Update:github.com/goccy/go-json
tov0.10.3
The update appears to be consistent with other changes in the file.
147-147
: Dependency Update:github.com/klauspost/compress
tov1.17.9
The update appears to be consistent with other changes in the file.
212-234
: Dependency Updates: Multiple dependencies
go.opentelemetry.io/contrib/propagators/b3
tov1.28.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace
tov1.28.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
tov1.28.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp
tov1.28.0
go.opentelemetry.io/otel/sdk
tov1.28.0
go.opentelemetry.io/otel/sdk/metric
tov1.28.0
go.opentelemetry.io/proto/otlp
tov1.3.1
golang.org/x/mod
tov0.19.0
google.golang.org/genproto/googleapis/api
tov0.0.0-20240701130421-f6361c86f094
google.golang.org/genproto/googleapis/rpc
tov0.0.0-20240701130421-f6361c86f094
google.golang.org/protobuf
tov1.34.2
The updates appear to be consistent with other changes in the file.
services/omnirpc/go.mod (5)
25-25
: Dependency Update:github.com/goccy/go-json
tov0.10.3
The update appears to be consistent with other changes in the file.
30-30
: Dependency Update:github.com/jarcoal/httpmock
tov1.3.1
The update appears to be consistent with other changes in the file.
36-36
: Dependency Update:github.com/puzpuzpuz/xsync
tov1.5.2
The update appears to be consistent with other changes in the file.
45-47
: Dependency Updates: Multiple dependencies
go.opentelemetry.io/otel
tov1.28.0
go.opentelemetry.io/otel/metric
tov1.28.0
go.opentelemetry.io/otel/trace
tov1.28.0
The updates appear to be consistent with other changes in the file.
243-263
: Dependency Updates: Multiple dependencies
go.opentelemetry.io/contrib/propagators/b3
tov1.28.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace
tov1.28.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
tov1.28.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp
tov1.28.0
go.opentelemetry.io/otel/sdk
tov1.28.0
go.opentelemetry.io/otel/sdk/metric
tov1.28.0
go.opentelemetry.io/proto/otlp
tov1.3.1
golang.org/x/mod
tov0.19.0
google.golang.org/genproto/googleapis/api
tov0.0.0-20240701130421-f6361c86f094
google.golang.org/genproto/googleapis/rpc
tov0.0.0-20240701130421-f6361c86f094
google.golang.org/protobuf
tov1.34.2
The updates appear to be consistent with other changes in the file.
ethergo/go.mod (6)
27-27
: Dependency Update:github.com/goccy/go-json
tov0.10.3
The update appears to be consistent with other changes in the file.
37-37
: Dependency Update:github.com/jarcoal/httpmock
tov1.3.1
The update appears to be consistent with other changes in the file.
59-62
: Dependency Updates: Multiple dependencies
go.opentelemetry.io/otel
tov1.28.0
go.opentelemetry.io/otel/metric
tov1.28.0
go.opentelemetry.io/otel/sdk
tov1.28.0
go.opentelemetry.io/otel/trace
tov1.28.0
The updates appear to be consistent with other changes in the file.
Line range hint
69-88
: Dependency Updates: Multiple dependencies
google.golang.org/protobuf
tov1.34.2
github.com/BurntSushi/toml
tov1.4.0
The updates appear to be consistent with other changes in the file.
Line range hint
167-201
: Dependency Updates: Multiple dependencies
github.com/gofrs/flock
tov0.12.0
github.com/klauspost/compress
tov1.17.9
The updates appear to be consistent with other changes in the file.
264-284
: Dependency Updates: Multiple dependencies
go.opentelemetry.io/contrib/propagators/b3
tov1.28.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace
tov1.28.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
tov1.28.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp
tov1.28.0
go.opentelemetry.io/otel/sdk/metric
tov1.28.0
go.opentelemetry.io/proto/otlp
tov1.3.1
google.golang.org/genproto/googleapis/api
tov0.0.0-20240701130421-f6361c86f094
google.golang.org/genproto/googleapis/rpc
tov0.0.0-20240701130421-f6361c86f094
The updates appear to be consistent with other changes in the file.
services/explorer/go.mod (10)
21-21
: Verify compatibility ofClickHouse/clickhouse-go/v2 v2.26.0
.Ensure that the updated version
v2.26.0
is compatible with the existing codebase and check for any breaking changes or deprecated features.
46-46
: Verify compatibility ofgo.opentelemetry.io/otel v1.28.0
.Ensure that the updated version
v1.28.0
is compatible with the existing codebase and check for any breaking changes or deprecated features.
47-47
: Verify compatibility ofgo.opentelemetry.io/otel/metric v1.28.0
.Ensure that the updated version
v1.28.0
is compatible with the existing codebase and check for any breaking changes or deprecated features.
146-146
: Verify compatibility ofgithub.aaakk.us.kg/goccy/go-json v0.10.3
.Ensure that the updated version
v0.10.3
is compatible with the existing codebase and check for any breaking changes or deprecated features.
147-147
: Verify compatibility ofgithub.aaakk.us.kg/gofrs/flock v0.12.0
.Ensure that the updated version
v0.12.0
is compatible with the existing codebase and check for any breaking changes or deprecated features.
261-261
: Verify compatibility ofgo.opentelemetry.io/contrib/propagators/b3 v1.28.0
.Ensure that the updated version
v1.28.0
is compatible with the existing codebase and check for any breaking changes or deprecated features.
263-263
: Verify compatibility ofgo.opentelemetry.io/otel/exporters/otlp/otlptrace v1.28.0
.Ensure that the updated version
v1.28.0
is compatible with the existing codebase and check for any breaking changes or deprecated features.
264-264
: Verify compatibility ofgo.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.28.0
.Ensure that the updated version
v1.28.0
is compatible with the existing codebase and check for any breaking changes or deprecated features.
265-265
: Verify compatibility ofgo.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.28.0
.Ensure that the updated version
v1.28.0
is compatible with the existing codebase and check for any breaking changes or deprecated features.
268-268
: Verify compatibility ofgo.opentelemetry.io/otel/sdk v1.28.0
.Ensure that the updated version
v1.28.0
is compatible with the existing codebase and check for any breaking changes or deprecated features.contrib/opbot/go.mod (7)
32-32
: Verify compatibility forgo.opentelemetry.io/otel/metric
update.Ensure that the update to
v1.28.0
does not introduce any breaking changes.Verification successful
The update to
go.opentelemetry.io/otel/metric
v1.28.0 does not introduce any breaking changes.The release notes mainly include performance improvements, new methods, and bug fixes. There are no breaking changes that would affect the existing functionality.
- No action needed.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility for `go.opentelemetry.io/otel/metric` update. # Test: Check release notes or changelog for breaking changes. curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases/tags/v1.28.0 | jq '.body'Length of output: 22734
146-146
: Verify compatibility forgithub.aaakk.us.kg/goccy/go-json
update.Ensure that the update to
v0.10.3
does not introduce any breaking changes.Verification successful
The update to
github.com/goccy/go-json
v0.10.3 is safe.The changes in this version are primarily bug fixes and internal improvements, with no breaking changes introduced.
- Addition of a license for string processing.
- Fixes for decoding structs with pointers, escaping issues in compact strings, and custom map marshaling.
- Replacement of the
ioutil
package with theio
package.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility for `github.com/goccy/go-json` update. # Test: Check release notes or changelog for breaking changes. curl -s https://api.github.com/repos/goccy/go-json/releases/tags/v0.10.3 | jq '.body'Length of output: 1097
33-33
: Verify compatibility forgo.opentelemetry.io/otel/trace
update.Ensure that the update to
v1.28.0
does not introduce any breaking changes.Verification successful
No breaking changes found in
go.opentelemetry.io/otel/trace
v1.28.0 update.The release notes for
go.opentelemetry.io/otel/trace
versionv1.28.0
do not indicate any breaking changes. The update includes performance improvements, new features, and bug fixes.
- Contrib/opbot/go.mod: The update to
v1.28.0
is safe and does not introduce breaking changes.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility for `go.opentelemetry.io/otel/trace` update. # Test: Check release notes or changelog for breaking changes. curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases/tags/v1.28.0 | jq '.body'Length of output: 22734
10-10
: Verify compatibility forgithub.aaakk.us.kg/dubonzi/otelresty
update.Ensure that the update to
v1.3.0
does not introduce any breaking changes.
178-178
: Verify compatibility forgithub.aaakk.us.kg/klauspost/compress
update.Ensure that the update to
v1.17.9
does not introduce any breaking changes.Verification successful
The update to
github.com/klauspost/compress
v1.17.9 is compatible and does not introduce breaking changes.The dependency is used indirectly across multiple services, and the release notes do not indicate any breaking changes.
contrib/opbot/go.mod
services/scribe/go.mod
services/explorer/go.mod
services/omnirpc/go.mod
services/cctp-relayer/go.mod
services/rfq/go.mod
ethergo/go.mod
agents/go.mod
core/go.mod
contrib/screener-api/go.mod
contrib/promexporter/go.mod
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility for `github.com/klauspost/compress` update. # Test: Check release notes or changelog for breaking changes. curl -s https://api.github.com/repos/klauspost/compress/releases/tags/v1.17.9 | jq '.body'Length of output: 828
Script:
#!/bin/bash # Description: Search for occurrences of `github.com/klauspost/compress` in the codebase. # Find all occurrences of the dependency in the codebase. rg 'github.com/klauspost/compress'Length of output: 9378
31-31
: Verify compatibility forgo.opentelemetry.io/otel
update.Ensure that the update to
v1.28.0
does not introduce any breaking changes.
147-147
: Verify compatibility forgithub.aaakk.us.kg/gofrs/flock
update.Ensure that the update to
v0.12.0
does not introduce any breaking changes.Verification successful
Verified compatibility for
github.com/gofrs/flock
update.The update to
v0.12.0
ofgithub.aaakk.us.kg/gofrs/flock
does not introduce any breaking changes for its usage intools/abigen/internal/etherscan/ratelimiter.go
.
- The
flock.New
andflock.TryLockContext
methods are compatible with the new version.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility for `github.com/gofrs/flock` update. # Test: Check release notes or changelog for breaking changes. curl -s https://api.github.com/repos/gofrs/flock/releases/tags/v0.12.0 | jq '.body'Length of output: 760
Script:
#!/bin/bash # Description: Find usage of `github.com/gofrs/flock` within the codebase. # Search for import statements of `github.com/gofrs/flock`. rg 'github.com/gofrs/flock' --glob='*.go'Length of output: 114
Script:
#!/bin/bash # Description: Extract and review the usage of `github.com/gofrs/flock` in the identified file. # Display the relevant lines of code in `tools/abigen/internal/etherscan/ratelimiter.go`. rg -A 10 -B 10 'github.com/gofrs/flock' tools/abigen/internal/etherscan/ratelimiter.goLength of output: 355
Script:
#!/bin/bash # Description: Extract and review the complete implementation of `fileRateLimiter` in the identified file. # Display the complete implementation of `fileRateLimiter` in `tools/abigen/internal/etherscan/ratelimiter.go`. rg -A 50 'type fileRateLimiter struct' tools/abigen/internal/etherscan/ratelimiter.goLength of output: 1863
services/scribe/go.mod (6)
56-56
: Verify compatibility forgo.opentelemetry.io/otel
update.Ensure that the update to
v1.28.0
does not introduce any breaking changes.Verification successful
Verify compatibility for
go.opentelemetry.io/otel
update.The update to
v1.28.0
does not introduce any breaking changes. The release notes indicate enhancements, fixes, and performance improvements without breaking existing functionality.
- File:
services/scribe/go.mod
- Line: 56
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility for `go.opentelemetry.io/otel` update. # Test: Check release notes or changelog for breaking changes. curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases/tags/v1.28.0 | jq '.body'Length of output: 22734
57-57
: Verify compatibility forgo.opentelemetry.io/otel/metric
update.Ensure that the update to
v1.28.0
does not introduce any breaking changes.Verification successful
The update to
go.opentelemetry.io/otel/metric
v1.28.0 is compatible.The changelog for version
v1.28.0
does not indicate any breaking changes. The update includes performance improvements, new features, and minor fixes.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility for `go.opentelemetry.io/otel/metric` update. # Test: Check release notes or changelog for breaking changes. curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases/tags/v1.28.0 | jq '.body'Length of output: 22734
198-198
: Verify compatibility forgithub.aaakk.us.kg/klauspost/compress
update.Ensure that the update to
v1.17.9
does not introduce any breaking changes.Verification successful
Update to
github.com/klauspost/compress
v1.17.9 is compatible.The release notes for
v1.17.9
indicate minor improvements and fixes without any breaking changes. The update should be safe to use.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility for `github.com/klauspost/compress` update. # Test: Check release notes or changelog for breaking changes. curl -s https://api.github.com/repos/klauspost/compress/releases/tags/v1.17.9 | jq '.body'Length of output: 828
65-65
: Verify compatibility forgoogle.golang.org/protobuf
update.Ensure that the update to
v1.34.2
does not introduce any breaking changes.Verification successful
Verify compatibility for
google.golang.org/protobuf
update.The release notes for
v1.34.2
indicate minor features and bug fixes, with no breaking changes. To ensure complete compatibility, verify if any of the updated features or fixed bugs are used in the codebase.
No issues found with the
google.golang.org/protobuf
update.The update to
v1.34.2
includes minor features and bug fixes with no breaking changes. Additionally, there are no references to the updated features or fixed bugs in the codebase, indicating that the update should not cause any issues.
- The updated feature
legacy_unmarshal_json_enum
is not used in the codebase.- The bug fixes related to
descriptorpb
,lazy decoding
,desc validator
, andFieldDescriptor.Kind
are not referenced in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility for `google.golang.org/protobuf` update. # Test: Check release notes or changelog for breaking changes. curl -s https://api.github.com/repos/protocolbuffers/protobuf-go/releases/tags/v1.34.2 | jq '.body'Length of output: 753
Script:
#!/bin/bash # Description: Verify usage of updated features or fixed bugs in the codebase. # Search for references to the updated feature `legacy_unmarshal_json_enum` rg 'legacy_unmarshal_json_enum' # Search for references to the bug fixes in the codebase rg 'descriptorpb' rg 'lazy decoding' rg 'desc validator' rg 'FieldDescriptor.Kind'Length of output: 118
63-63
: Verify compatibility forgoogle.golang.org/genproto/googleapis/api
update.Ensure that the update to
v0.0.0-20240701130421-f6361c86f094
does not introduce any breaking changes.Verification successful
No compatibility issues found for the
google.golang.org/genproto/googleapis/api
update.The dependency
google.golang.org/genproto/googleapis/api/annotations
is used in a generated protobuf file and does not directly impact the Go code. There are no apparent compatibility issues with the update tov0.0.0-20240701130421-f6361c86f094
.
services/scribe/grpc/types/types/v1/service.pb.go
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility for `google.golang.org/genproto/googleapis/api` update. # Test: Check release notes or changelog for breaking changes. curl -s https://api.github.com/repos/googleapis/go-genproto/releases/tags/v0.0.0-20240701130421-f6361c86f094 | jq '.body'Length of output: 126
Script:
#!/bin/bash # Description: Find usages of the updated dependency `google.golang.org/genproto/googleapis/api` in the codebase. # Search for import statements of the updated dependency in the Go files. rg 'google.golang.org/genproto/googleapis/api' --glob '*.go'Length of output: 169
Script:
#!/bin/bash # Description: Extract and review the relevant portions of the `services/scribe/grpc/types/types/v1/service.pb.go` file to verify compatibility. # Display the relevant lines in the file where the dependency is used. rg 'google.golang.org/genproto/googleapis/api/annotations' services/scribe/grpc/types/types/v1/service.pb.go -A 10 -B 10Length of output: 705
58-58
: Verify compatibility forgo.opentelemetry.io/otel/trace
update.Ensure that the update to
v1.28.0
does not introduce any breaking changes.Verification successful
Verify compatibility for
go.opentelemetry.io/otel/trace
update.The update to
v1.28.0
does not introduce any breaking changes based on the release notes and the usage patterns found in the codebase.
- No breaking changes were found in the release notes for
go.opentelemetry.io/otel/trace
v1.28.0.- The usage of
trace.Span
andtrace.Tracer
in the codebase appears to be consistent with the typical usage patterns.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility for `go.opentelemetry.io/otel/trace` update. # Test: Check release notes or changelog for breaking changes. curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases/tags/v1.28.0 | jq '.body'Length of output: 22734
Script:
#!/bin/bash # Description: Search for the usage of `go.opentelemetry.io/otel/trace` in the codebase. # Find all Go files that import `go.opentelemetry.io/otel/trace` fd --type f --extension go --exec grep -l 'go.opentelemetry.io/otel/trace' {} + # Search for functions and methods that use `trace` from `go.opentelemetry.io/otel/trace` ast-grep --lang go --pattern 'trace.$_'Length of output: 65226
services/cctp-relayer/go.mod (6)
25-25
: Dependency Update Approved:go.opentelemetry.io/otel
The version update to
v1.28.0
is consistent with other dependency updates.
26-26
: Dependency Update Approved:go.opentelemetry.io/otel/trace
The version update to
v1.28.0
is consistent with othergo.opentelemetry.io/otel
updates.
110-110
: Dependency Update Approved:github.com/dubonzi/otelresty
The version update to
v1.3.0
is consistent with other dependency updates.
138-138
: Dependency Update Approved:github.com/goccy/go-json
The version update to
v0.10.3
is consistent with other dependency updates.
139-139
: Dependency Update Approved:github.com/gofrs/flock
The version update to
v0.12.0
is consistent with other dependency updates.
182-182
: Dependency Update Approved:github.com/klauspost/compress
The version update to
v1.17.9
is consistent with other dependency updates.services/rfq/go.mod (10)
11-11
: Dependency Update Approved:github.com/dubonzi/otelresty
The version update to
v1.3.0
is consistent with other dependency updates.
36-36
: Dependency Update Approved:go.opentelemetry.io/otel
The version update to
v1.28.0
is consistent with other dependency updates.
37-37
: Dependency Update Approved:go.opentelemetry.io/otel/metric
The version update to
v1.28.0
is consistent with othergo.opentelemetry.io/otel
updates.
38-38
: Dependency Update Approved:go.opentelemetry.io/otel/trace
The version update to
v1.28.0
is consistent with othergo.opentelemetry.io/otel
updates.
154-154
: Dependency Update Approved:github.com/goccy/go-json
The version update to
v0.10.3
is consistent with other dependency updates.
155-155
: Dependency Update Approved:github.com/gofrs/flock
The version update to
v0.12.0
is consistent with other dependency updates.
198-198
: Dependency Update Approved:github.com/klauspost/compress
The version update to
v1.17.9
is consistent with other dependency updates.
277-277
: Dependency Update Approved:go.opentelemetry.io/contrib/propagators/b3
The version update to
v1.28.0
is consistent with othergo.opentelemetry.io/otel
updates.
279-279
: Dependency Update Approved:go.opentelemetry.io/otel/exporters/otlp/otlptrace
The version update to
v1.28.0
is consistent with othergo.opentelemetry.io/otel
updates.
280-280
: Dependency Update Approved:go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
The version update to
v1.28.0
is consistent with othergo.opentelemetry.io/otel
updates.agents/go.mod (6)
8-8
: Approved: Dependency UpdateThe update from
github.com/BurntSushi/toml v1.3.2
tov1.4.0
is approved.
36-36
: Approved: Dependency UpdateThe update from
go.opentelemetry.io/otel v1.27.0
tov1.28.0
is approved.
37-37
: Approved: Dependency UpdateThe update from
go.opentelemetry.io/otel/trace v1.27.0
tov1.28.0
is approved.
80-80
: Approved: Dependency UpdateThe update from
github.com/gofrs/flock v0.8.1
tov0.12.0
is approved.
193-193
: Approved: Dependency UpdateThe update from
github.com/goccy/go-json v0.10.2
tov0.10.3
is approved.
228-228
: Approved: Dependency UpdateThe update from
github.com/klauspost/compress v1.17.8
tov1.17.9
is approved..github/workflows/go.yml (4)
114-114
: Approved: Dependency UpdateThe update from
actions/cache v3
tov4
is approved.
128-128
: Approved: Dependency UpdateThe update from
actions/setup-go v4
tov5
is approved.
264-264
: Approved: Dependency UpdateThe update from
actions/setup-go v4
tov5
is approved.
269-269
: Approved: Dependency UpdateThe update from
actions/cache v3
tov4
is approved.contrib/screener-api/go.mod (6)
16-16
: Verify compatibility ofgithub.aaakk.us.kg/dubonzi/otelresty
update.Ensure that the update from
v1.2.0
tov1.3.0
does not introduce any breaking changes and is compatible with the existing codebase.
29-29
: Verify compatibility ofgo.opentelemetry.io/otel
update.Ensure that the update from
v1.27.0
tov1.28.0
does not introduce any breaking changes and is compatible with the existing codebase.
89-89
: Verify compatibility ofgithub.aaakk.us.kg/goccy/go-json
update.Ensure that the update from
v0.10.2
tov0.10.3
does not introduce any breaking changes and is compatible with the existing codebase.
109-109
: Verify compatibility ofgithub.aaakk.us.kg/klauspost/compress
update.Ensure that the update from
v1.17.8
tov1.17.9
does not introduce any breaking changes and is compatible with the existing codebase.
163-163
: Verify compatibility ofgo.opentelemetry.io/contrib/propagators/b3
update.Ensure that the update from
v1.27.0
tov1.28.0
does not introduce any breaking changes and is compatible with the existing codebase.
165-165
: Verify compatibility ofgo.opentelemetry.io/otel/exporters/otlp/otlptrace
update.Ensure that the update from
v1.27.0
tov1.28.0
does not introduce any breaking changes and is compatible with the existing codebase.contrib/opbot/botmd/commands.go (1)
252-252
: Verify correctness ofrfqRefund
command update.Ensure that the removal of the
origin_chainid
parameter does not affect the functionality and the command works as expected with only thetx
parameter.
@@ -11,7 +11,7 @@ jobs: | |||
stale-prs: | |||
runs-on: ubuntu-latest | |||
steps: | |||
- uses: actions/stale@v8 | |||
- uses: actions/stale@v9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
Breaking changes detected in actions/stale
v9.
The update from v8
to v9
of actions/stale
introduces several breaking changes:
- The action is now stateful and the state is retained across runs.
- The runtime has been updated to Node.js 20, which may introduce breaking changes from Node.js 16.
- Other specific changes affecting the workflow behavior.
Please review the release notes and adapt your workflow accordingly to accommodate these breaking changes.
- File:
.github/workflows/close-stale.yml
- Line: 14
Analysis chain
Verify compatibility of actions/stale
v9.
Ensure that the update from v8
to v9
of actions/stale
is compatible and does not introduce breaking changes. Check the release notes for any significant changes.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify compatibility of `actions/stale` v9.
# Test: Check for breaking changes in the release notes. Expect: No breaking changes.
curl -s https://api.github.com/repos/actions/stale/releases | jq '.[].body' | grep -i "breaking"
Length of output: 7044
go.opentelemetry.io/otel/trace v1.27.0 | ||
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v1.28.0 | ||
go.opentelemetry.io/otel/metric v1.28.0 | ||
go.opentelemetry.io/otel/sdk v1.28.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
Issues found with the update to go.opentelemetry.io/otel/sdk
v1.28.0.
The update to v1.28.0
introduces breaking changes in the TracerProvider
, Tracer
, and Span
interfaces. The following instances in the codebase need to be reviewed and potentially updated to ensure compatibility:
-
TracerProvider
implementations or uses:services/rfq/api/client/client.go
services/rfq/relayer/relapi/client.go
services/scribe/graphql/server/gin.go
services/scribe/grpc/server/server.go
services/explorer/graphql/server/gin.go
contrib/opbot/signoz/authed.go
contrib/opbot/signoz/unauthed.go
core/metrics/metrics.go
core/metrics/pyroscope.go
core/metrics/null.go
contrib/screener-api/chainalysis/chainalysisapi.go
core/metrics/base.go
contrib/screener-api/client/client.go
agents/agents/executor/executor.go
agents/agents/guard/guard.go
-
Tracer
implementations or uses:services/rfq/api/client/client.go
services/rfq/api/db/sql/sqlite/sqlite.go
services/rfq/relayer/service/chainindexer.go
services/rfq/guard/service/guard.go
services/rfq/guard/service/handlers.go
services/rfq/relayer/service/handlers.go
services/rfq/relayer/reldb/sqlite/sqlite.go
services/rfq/relayer/service/statushandler.go
services/rfq/relayer/service/relayer.go
services/rfq/relayer/pricer/fee_pricer.go
services/rfq/relayer/inventory/synapse.go
services/rfq/relayer/inventory/manager.go
services/rfq/relayer/inventory/circle.go
services/rfq/relayer/quoter/quoter.go
services/scribe/graphql/server/gin.go
services/rfq/guard/guarddb/sqlite/sqlite.go
services/scribe/grpc/server/server.go
services/scribe/service/indexer/indexer.go
services/scribe/db/datastore/sql/mysql/store.go
services/scribe/db/datastore/sql/sqlite/store.go
services/scribe/db/datastore/sql/base/lastindexed.go
services/explorer/api/server.go
services/omnirpc/rpcinfo/latency.go
services/omnirpc/modules/harmonyproxy/harmonyproxy.go
services/omnirpc/proxy/server.go
services/omnirpc/proxy/forwarder.go
services/omnirpc/modules/confirmedtofinalized/finalizedproxy.go
services/omnirpc/modules/receiptsbackup/receiptsbackup.go
services/cctp-relayer/relayer/relayer.go
services/cctp-relayer/relayer/circle.go
services/cctp-relayer/relayer/synapse.go
services/cctp-relayer/db/sql/sqlite/sqlite.go
ethergo/listener/suite_test.go
ethergo/listener/listener.go
ethergo/submitter/chain_queue.go
ethergo/submitter/submitter.go
ethergo/submitter/queue.go
ethergo/submitter/db/txdb/store.go
ethergo/client/client.go
ethergo/client/hmy.go
contrib/opbot/sql/sqlite/sqlite.go
contrib/opbot/generated/featureSet.go
core/metrics/tester.go
core/metrics/spanutils.go
contrib/screener-api/screener/screener.go
contrib/promexporter/exporters/bridge.go
contrib/promexporter/exporters/exporter.go
core/metrics/instrumentation/httpcapture/http.go
core/metrics/instrumentation/httpcapture/http_test.go
contrib/screener-api/db/sql/sqlite/sqlite.go
agents/agents/executor/cmd/commands.go
agents/agents/executor/executor.go
agents/agents/notary/cmd/commands.go
agents/agents/notary/db/sql/sqlite/sqlite.go
agents/agents/executor/db/sql/sqlite/store.go
agents/agents/executor/db/sql/mysql/store.go
agents/agents/guard/cmd/commands.go
agents/agents/guard/db/sql/sqlite/sqlite.go
-
Span
implementations or uses:services/rfq/api/client/client.go
services/rfq/api/db/sql/sqlite/sqlite.go
services/rfq/relayer/service/chainindexer.go
services/rfq/guard/service/guard.go
services/rfq/guard/service/handlers.go
services/rfq/relayer/service/handlers.go
services/rfq/relayer/reldb/sqlite/sqlite.go
services/rfq/relayer/service/statushandler.go
services/rfq/relayer/service/relayer.go
services/rfq/relayer/pricer/fee_pricer.go
services/rfq/relayer/inventory/synapse.go
services/rfq/relayer/inventory/rebalance.go
services/rfq/relayer/inventory/manager.go
services/rfq/relayer/inventory/circle.go
services/rfq/relayer/quoter/quoter.go
services/scribe/graphql/server/gin.go
services/rfq/guard/guarddb/sqlite/sqlite.go
services/scribe/service/indexer/indexer.go
services/scribe/db/datastore/sql/mysql/store.go
services/scribe/db/datastore/sql/sqlite/store.go
services/scribe/db/datastore/sql/base/lastindexed.go
services/explorer/api/server.go
services/omnirpc/rpcinfo/latency.go
services/omnirpc/modules/harmonyproxy/harmonyproxy.go
services/omnirpc/proxy/forwarder.go
services/omnirpc/proxy/export_test.go
services/omnirpc/modules/confirmedtofinalized/finalizedproxy.go
services/omnirpc/modules/receiptsbackup/receiptsbackup.go
services/cctp-relayer/relayer/relayer.go
services/cctp-relayer/relayer/circle.go
services/cctp-relayer/relayer/synapse.go
services/cctp-relayer/db/sql/sqlite/sqlite.go
ethergo/listener/suite_test.go
ethergo/listener/listener.go
ethergo/submitter/chain_queue.go
ethergo/submitter/submitter.go
ethergo/submitter/queue.go
ethergo/submitter/db/txdb/store.go
ethergo/client/client.go
ethergo/client/hmy.go
contrib/opbot/sql/sqlite/sqlite.go
contrib/opbot/generated/queryParams.go
contrib/opbot/generated/response.go
core/metrics/tester.go
core/metrics/spanutils.go
contrib/screener-api/screener/screener.go
contrib/promexporter/exporters/bridge.go
contrib/promexporter/exporters/exporter.go
core/metrics/instrumentation/httpcapture/http.go
core/metrics/instrumentation/httpcapture/http_test.go
contrib/screener-api/db/sql/sqlite/sqlite.go
agents/agents/executor/cmd/commands.go
agents/agents/executor/executor.go
agents/agents/notary/cmd/commands.go
agents/agents/notary/db/sql/sqlite/sqlite.go
agents/agents/executor/db/sql/sqlite/store.go
agents/agents/executor/db/sql/mysql/store.go
agents/agents/guard/cmd/commands.go
agents/agents/guard/db/sql/sqlite/sqlite.go
Please review these instances and ensure that the necessary updates are made to maintain compatibility with go.opentelemetry.io/otel/sdk
v1.28.0.
Analysis chain
Verify compatibility of go.opentelemetry.io/otel/sdk
v1.28.0.
Ensure that the update from v1.27.0
to v1.28.0
of go.opentelemetry.io/otel/sdk
is compatible and does not introduce breaking changes. Check the release notes for any significant changes.
Verify compatibility of go.opentelemetry.io/otel/sdk
v1.28.0.
The update to v1.28.0
introduces breaking changes in the TracerProvider
, Tracer
, and Span
interfaces. Ensure that these changes do not affect the existing codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify compatibility of `go.opentelemetry.io/otel/sdk` v1.28.0.
# Test: Check for breaking changes in the release notes. Expect: No breaking changes.
curl -s https://api.github.com/repos/open-telemetry/opentelemetry-go/releases | jq '.[].body' | grep -i "breaking"
Length of output: 10794
Script:
#!/bin/bash
# Description: Search for implementations or uses of `TracerProvider`, `Tracer`, and `Span` in the codebase to verify compatibility with `go.opentelemetry.io/otel/sdk` v1.28.0.
# Find all Go files in the repository
go_files=$(fd --type f --extension go)
# Search for `TracerProvider` implementations or uses
echo "Searching for TracerProvider implementations or uses..."
grep -r "TracerProvider" $go_files
# Search for `Tracer` implementations or uses
echo "Searching for Tracer implementations or uses..."
grep -r "Tracer" $go_files
# Search for `Span` implementations or uses
echo "Searching for Span implementations or uses..."
grep -r "Span" $go_files
Length of output: 326831
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (9)
agents/go.sum
is excluded by!**/*.sum
contrib/opbot/go.sum
is excluded by!**/*.sum
contrib/promexporter/go.sum
is excluded by!**/*.sum
go.work.sum
is excluded by!**/*.sum
services/cctp-relayer/go.sum
is excluded by!**/*.sum
services/explorer/go.sum
is excluded by!**/*.sum
services/omnirpc/go.sum
is excluded by!**/*.sum
services/rfq/go.sum
is excluded by!**/*.sum
services/scribe/go.sum
is excluded by!**/*.sum
Files selected for processing (5)
- agents/go.mod (9 hunks)
- services/cctp-relayer/go.mod (7 hunks)
- services/omnirpc/go.mod (6 hunks)
- services/rfq/go.mod (7 hunks)
- services/scribe/go.mod (5 hunks)
Files skipped from review as they are similar to previous changes (5)
- agents/go.mod
- services/cctp-relayer/go.mod
- services/omnirpc/go.mod
- services/rfq/go.mod
- services/scribe/go.mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Updated
clients
map type in/services/omnirpc/http/fasthttp.go
toxsync.MapOf[string, FastClient]
- Changed
resMap
field type inForwarder
struct in/services/omnirpc/proxy/export_test.go
tomap[string][]rawResponse
- Updated
xsync.MapOf
types in/services/omnirpc/proxy/forwarder.go
tostring, []rawResponse
andstring, error
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Updated OpenTelemetry semantic conventions to v1.26.0 in
/core/metrics/base.go
- Updated OpenTelemetry semantic conventions to v1.26.0 in
/core/metrics/instrumentation/otelginmetrics/config.go
- Updated OpenTelemetry semantic conventions to v1.26.0 in
/core/metrics/instrumentation/otelginmetrics/example/main.go
- Updated OpenTelemetry semantic conventions to v1.26.0 in
/core/metrics/instrumentation/otelginmetrics/middleware.go
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Updated semantic convention key in
/core/metrics/instrumentation/otelginmetrics/config.go
for HTTP request methods tosemconv.HTTPRequestMethodKey
- Introduced
statusKey
constant in/core/metrics/instrumentation/otelginmetrics/middleware.go
for HTTP status code attribute - Middleware function in
/core/metrics/instrumentation/otelginmetrics/middleware.go
now usesstatusKey
instead ofsemconv.HTTPStatusCodeKey
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Description
Some weekend cleaning (inspired by #16)
Summary by CodeRabbit
go.mod
files across services, ensuring compatibility and enhancements from newer versions.