fix semconv changes [goreleaser]

synapsecns · Jul 6, 2024 · a41b903 · a41b903
1 parent 3427d97
commit a41b903
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/core/metrics/instrumentation/otelginmetrics/config.go b/core/metrics/instrumentation/otelginmetrics/config.go
@@ -32,7 +32,7 @@ func defaultConfig() *config {
 
 var DefaultAttributes = func(serverName, route string, request *http.Request) []attribute.KeyValue {
 	attrs := []attribute.KeyValue{
-		semconv.HTTPMethodKey.String(request.Method),
+		semconv.HTTPRequestMethodKey.String(request.Method),
 	}
 
 	if serverName != "" {

diff --git a/core/metrics/instrumentation/otelginmetrics/middleware.go b/core/metrics/instrumentation/otelginmetrics/middleware.go
@@ -1,13 +1,16 @@
 package otelginmetrics
 
 import (
+	"go.opentelemetry.io/otel/attribute"
 	"net/http"
 	"time"
 
 	"github.com/gin-gonic/gin"
 	semconv "go.opentelemetry.io/otel/semconv/v1.26.0"
 )
 
+const statusKey = attribute.Key("http.status_code")
+
 // Middleware returns middleware that will trace incoming requests.
 // The service parameter should describe the name of the (virtual)
 // server handling the request.
@@ -47,7 +50,7 @@ func Middleware(service string, options ...Option) gin.HandlerFunc {
 
 			if cfg.groupedStatus {
 				code := int(ginCtx.Writer.Status()/100) * 100
-				resAttributes = append(resAttributes, semconv.HTTPStatusCodeKey.Int(code))
+				resAttributes = append(resAttributes, statusKey.Int(code))
 			} else {
 				resAttributes = append(resAttributes, semconv.HTTPResponseStatusCodeKey.Int(ginCtx.Writer.Status()))
 			}