Allowed to return null for query_builder #6594
Conversation
JonEastman
commented
May 21, 2016
JonEastman
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.8 |
| Fixed tickets | #5934 |
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.8 | Fixed tickets | symfony#5934
|
Thanks, can you please update this line too? |
| @@ -202,9 +202,9 @@ query_builder | |||
| Allows you to create a custom query for your choices. See | |||
| :ref:`ref-form-entity-query-builder` for an example. | |||
|
|
|||
| The value of this option can either be a ``QueryBuilder`` object or a Closure. | |||
| The value of this option can either be a ``QueryBuilder`` object, a Closure or null. | |||
There was a problem hiding this comment.
unless I'm missing something, it's not the option value that can be null. Instead, the closure can return null.
There was a problem hiding this comment.
|
Hi @JonEastman! Thanks for your contribution, I've left 2 minor comments. |
|
@wouterj I made the suggested changes, let me know what you think |
|
👍 Looks good! |
|
👍 |
| When using a Closure, you will be passed the ``EntityRepository`` of the entity | ||
| as the only argument and should return a ``QueryBuilder``. If you'd like to display a list of empty entries, you can return null in the query_builder closure. | ||
| as the only argument and should return a ``QueryBuilder``. | ||
| If you'd like to display a list of empty entries, you can return ``null`` in the closure. |
There was a problem hiding this comment.
Unless I'm missing something when null is returned it loads all entities.
There was a problem hiding this comment.
When you set the option to null, but not when return null in the closure, isn't it?
There was a problem hiding this comment.
Why that? The only difference is that it's conditional. ?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok so I've missed the point of that feature, thanks for the enlightening!
There was a problem hiding this comment.
@xabbuh Looks like symfony/symfony@317d30b has not made it to the core !? (neither master nor 2.8)
There was a problem hiding this comment.
Looks like there was something wrong with the commit and it was fixed in symfony/symfony@eb08baa
The tests exists and passes: https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php#L212-L223
There was a problem hiding this comment.
This PR was merged into the 2.3 branch. Discussion ---------- Fixed query_builder option doc fix: 2.3+ ref #6594 (comment) Commits ------- 45f586b Fixed query_builder option
| @@ -202,9 +202,10 @@ query_builder | |||
| Allows you to create a custom query for your choices. See | |||
| :ref:`ref-form-entity-query-builder` for an example. | |||
|
|
|||
| The value of this option can either be a ``QueryBuilder`` object, a Closure or null. | |||
| The value of this option can either be a ``QueryBuilder`` object, a Closure or ``null``. | |||
There was a problem hiding this comment.
Needs a rebase here when #6596 is merged in 2.8
There was a problem hiding this comment.
I'll take care of that while merging.
This PR was squashed before being merged into the 2.8 branch (closes #6594). Discussion ---------- Allowed to return null for query_builder | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.8 | Fixed tickets | #5934 Commits ------- f84a1eb Allowed to return null for query_builder
|
Thanks @JonEastman! I've merged your PR in the documentation and added a little versionadded box indicating that this is a new feature in f64fe19 (fixed the version in a later commit). |
