Fix "[Form] Add flexibility for EntityType"

This fixes commit e0a1294.
symfony · Aug 2, 2015 · eb08baa · eb08baa
1 parent a5a9385
commit eb08baa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/src/Symfony/Bridge/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php b/src/Symfony/Bridge/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php
@@ -30,7 +30,7 @@ class ORMQueryBuilderLoader implements EntityLoaderInterface
      *
      * This property should only be accessed through queryBuilder.
      *
-     * @var QueryBuilder|null
+     * @var QueryBuilder
      */
     private $queryBuilder;
 
@@ -68,7 +68,7 @@ public function __construct($queryBuilder, $manager = null, $class = null)
 
             $queryBuilder = $queryBuilder($manager->getRepository($class));
 
-            if (null !== $queryBuilder && !$queryBuilder instanceof QueryBuilder) {
+            if (!$queryBuilder instanceof QueryBuilder) {
                 throw new UnexpectedTypeException($queryBuilder, 'Doctrine\ORM\QueryBuilder');
             }
         }
@@ -81,10 +81,6 @@ public function __construct($queryBuilder, $manager = null, $class = null)
      */
     public function getEntities()
     {
-        if (null === $this->queryBuilder) {
-            return array();
-        }
-
         return $this->queryBuilder->getQuery()->execute();
     }
 
@@ -93,10 +89,6 @@ public function getEntities()
      */
     public function getEntitiesByIds($identifier, array $values)
     {
-        if (null === $this->queryBuilder) {
-            return array();
-        }
-
         $qb = clone ($this->queryBuilder);
         $alias = current($qb->getRootAliases());
         $parameter = 'ORMQueryBuilderLoader_getEntitiesByIds_'.$identifier;

diff --git a/src/Symfony/Bridge/Doctrine/Form/Type/EntityType.php b/src/Symfony/Bridge/Doctrine/Form/Type/EntityType.php
@@ -30,7 +30,7 @@ public function configureOptions(OptionsResolver $resolver)
             if (is_callable($queryBuilder)) {
                 $queryBuilder = call_user_func($queryBuilder, $options['em']->getRepository($options['class']));
 
-                if (!$queryBuilder instanceof QueryBuilder) {
+                if (null !== $queryBuilder && !$queryBuilder instanceof QueryBuilder) {
                     throw new UnexpectedTypeException($queryBuilder, 'Doctrine\ORM\QueryBuilder');
                 }
             }

diff --git a/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php b/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php
@@ -215,7 +215,7 @@ public function testConfigureQueryBuilderWithClosureReturningNonQueryBuilder()
 
     public function testConfigureQueryBuilderWithClosureReturningNull()
     {
-        $field = $this->factory->createNamed('name', 'entity', null, array(
+        $field = $this->factory->createNamed('name', 'Symfony\Bridge\Doctrine\Form\Type\EntityType', null, array(
             'em' => 'default',
             'class' => self::SINGLE_IDENT_CLASS,
             'query_builder' => function () {