Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continues #4307 #4400

Merged
merged 2 commits into from
Nov 20, 2014
Merged

Continues #4307 #4400

merged 2 commits into from
Nov 20, 2014

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Oct 31, 2014

Continues #4307

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets -

Original PR description:

"name" in requirements is confusing, I had problem for doing the same and then after 2 days I found that the "name" should be same as the parameter, it is not part of symfony config

SamanShafigh and others added 2 commits October 31, 2014 12:01
@SamanShafigh @wouterj
Update slash_in_parameter.rst
48f453d 
"name" in requirements is confusing, I had problem for doing the same and then after 2 days I found that the "name" should be same as the parameter, it is not part of symfony config

   requirements: 
        name: .+
@wouterj
Changed userName to username
b412780
@wouterj wouterj mentioned this pull request Oct 31, 2014
Closed
@weaverryan
Copy link
Member

Thanks for finishing this up!

@weaverryan weaverryan merged commit b412780 into 2.3 Nov 20, 2014
weaverryan added a commit that referenced this pull request Nov 20, 2014
@weaverryan
minor #4400 Continues #4307 (SamanShafigh, WouterJ)
188dd1f 
This PR was merged into the 2.3 branch.

Discussion
----------

Continues #4307

Continues #4307

| Q   | A
| --- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | all
| Fixed tickets | -

Original PR description:

 > "name" in requirements is confusing, I had problem for doing the same and then after 2 days I found that the "name" should be same as the parameter, it is not part of symfony config

Commits
-------

b412780 Changed userName to username
48f453d Update slash_in_parameter.rst
@weaverryan weaverryan deleted the SamanShafigh-patch-1 branch November 20, 2014 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wouterj @weaverryan @SamanShafigh